From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Gunthorpe Subject: Re: [RFC PATCH 3/9] of: mtd: add NAND timings retrieval support Date: Thu, 9 Jan 2014 10:35:05 -0700 Message-ID: <20140109173505.GB8899@obsidianresearch.com> References: <1389190924-26226-1-git-send-email-b.brezillon@overkiz.com> <1389190924-26226-4-git-send-email-b.brezillon@overkiz.com> <20140108183418.GA12358@obsidianresearch.com> <52CDA032.3010804@overkiz.com> <20140108191339.GB12358@obsidianresearch.com> <52CE5F82.6070802@overkiz.com> Reply-To: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: <52CE5F82.6070802-ZNYIgs0QAGpBDgjK7y7TUQ@public.gmane.org> List-Post: , List-Help: , List-Archive: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org List-Subscribe: , List-Unsubscribe: , Content-Disposition: inline To: boris brezillon Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Russell King , linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dev-3kdeTeqwOZ9EV1b7eY7vFQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Rob Landley , Grant Likely , Maxime Ripard , David Woodhouse , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On Thu, Jan 09, 2014 at 09:36:18AM +0100, boris brezillon wrote: > >You might want to check if you can boil down the DT timings from the > >huge list to just an ONFI mode number.. > > Sure, but the sunxi driver needs at least 19 of them... So does mvebu's NAND driver.. What I ment was you could have a onfi,nand-timing-mode = 0 in the DT. Each of the modes defines all ~19 parameters, higher modes are faster. Pick a mode value that fits all the parameters of the connected non-ONFI flash. This would be instead of defining each parameter individually.. Provide some helpers to convert from a onfi mode number to all the onfi defined timing parameters so that drivers can configure the HW.. Jason