From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lothar =?UTF-8?B?V2HDn21hbm4=?= Subject: Re: [PATCHv9 1/2] video: backlight: gpio-backlight: Add DT support. Date: Fri, 10 Jan 2014 16:30:00 +0100 Message-ID: <20140110163000.64dbeba9@ipc1.ka-ro> References: <1389366444-29449-1-git-send-email-denis@eukrea.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1389366444-29449-1-git-send-email-denis@eukrea.com> Sender: linux-gpio-owner@vger.kernel.org To: Denis Carikli Cc: Jingoo Han , linux-gpio@vger.kernel.org, Alexander Shiyan , Grant Likely , Mark Rutland , Richard Purdie , Laurent Pinchart , Rob Herring , Pawel Moll , Stephen Warren , Ian Campbell , devicetree@vger.kernel.org, Sascha Hauer , Shawn Guo , linux-arm-kernel@lists.infradead.org, Jean-Christophe Plagniol-Villard , Thierry Reding , Eric =?UTF-8?B?QsOpbmFyZA==?= List-Id: devicetree@vger.kernel.org Hi, Denis Carikli wrote: > Cc: Richard Purdie > Cc: Jingoo Han > Cc: Laurent Pinchart > Cc: Rob Herring > Cc: Pawel Moll > Cc: Mark Rutland > Cc: Stephen Warren > Cc: Ian Campbell > Cc: devicetree@vger.kernel.org > Cc: Sascha Hauer > Cc: Shawn Guo > Cc: linux-arm-kernel@lists.infradead.org > Cc: Lothar Wa=C3=9Fmann > Cc: Jean-Christophe Plagniol-Villard > Cc: Thierry Reding > Cc: Eric B=C3=A9nard > Signed-off-by: Denis Carikli > --- > ChangeLog v8->v9: > - Added Shawn Guo in the Cc list. > - The default-brightness-level is now a boolean default-on property, > the gpio is only touched if the gpio-backlight driver instance prob= es. > - The code and documentation was updated accordingly. >=20 > ChangeLog v7->v8: > - The default-state was renamed to default-brightness-level. > - default-brightness-level is now mandatory, like for backlight-pwm, > That way we avoid having to handle the case where it's not set, > which means that we would need not to set the gpio, but still > report a brightness value for sysfs, when not all gpio controllers = are > able to read the gpio value. > - switched the default-brightness-level to boolean values (0 or 1) in= stead > of using strings ("on", "off", "keep"). > - The documentation was updated accordingly. > - The example in the documentation now uses the dts gpio defines. > - The "backlight: gpio_backlight: Use a default state enum." patch wa= s then > dropped, becuase it is not necessary anymore. >=20 > ChangeLog v6->v7: > - removed a compilation warning with the removal of the useless ret d= eclaration. >=20 > ChangeLog v5->v6: > - The default state handling was reworked: > - it's now called default-state, and looks like the gpio-leds defau= lt-state. > - it now has a "keep" option, like for the gpio-leds. > - that "keep" option is the default when the default-state property= is not set. > - The documentation was updated accordingly. >=20 > ChangeLog v4->v5: > - The default-brightness property now defaults to 0 in the driver. > - def_value int becomes a bool. > - The check for the gpio validity has been reworked. > --- > .../bindings/video/backlight/gpio-backlight.txt | 19 +++++++ > drivers/video/backlight/gpio_backlight.c | 60 ++++++++++= +++++++--- > 2 files changed, 72 insertions(+), 7 deletions(-) > create mode 100644 Documentation/devicetree/bindings/video/backlight= /gpio-backlight.txt >=20 [...] > +static struct of_device_id gpio_backlight_of_match[] =3D { > + { .compatible =3D "gpio-backlight" }, > + { /* sentinel */ } > +}; > + > static struct platform_driver gpio_backlight_driver =3D { > .driver =3D { > .name =3D "gpio-backlight", > .owner =3D THIS_MODULE, > + .of_match_table =3D of_match_ptr(gpio_backlight_of_match), > useless use of of_match_ptr(). This would make sense, if the gpio_backlight_of_match struct was conditionally compiled in depending on CONFIG_OF. Since you unconditionally provide it you can use &gpio_backlight_of_match directly. Lothar Wa=C3=9Fmann --=20 ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstra=C3=9Fe 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Gesch=C3=A4ftsf=C3=BChrer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info@karo-electronics.de ___________________________________________________________ -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html