* [PATCH 6/7] devicetree: bindings: Document Krait performance monitor units (PMU) [not found] ` <1389221984-10973-1-git-send-email-sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> @ 2014-01-08 22:59 ` Stephen Boyd 2014-01-09 18:14 ` Will Deacon 0 siblings, 1 reply; 6+ messages in thread From: Stephen Boyd @ 2014-01-08 22:59 UTC (permalink / raw) To: Will Deacon Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA, linux-arm-msm-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, devicetree-u79uwXL29TY76Z2rM5mHXA Document the Krait PMU compatible string. Cc: <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> Signed-off-by: Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> --- Documentation/devicetree/bindings/arm/pmu.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/pmu.txt b/Documentation/devicetree/bindings/arm/pmu.txt index 3e1e498fea96..ce7cccb99d87 100644 --- a/Documentation/devicetree/bindings/arm/pmu.txt +++ b/Documentation/devicetree/bindings/arm/pmu.txt @@ -16,6 +16,7 @@ Required properties: "arm,arm11mpcore-pmu" "arm,arm1176-pmu" "arm,arm1136-pmu" + "qcom,krait-pmu" - interrupts : 1 combined interrupt or 1 per core. Example: -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 6/7] devicetree: bindings: Document Krait performance monitor units (PMU) 2014-01-08 22:59 ` [PATCH 6/7] devicetree: bindings: Document Krait performance monitor units (PMU) Stephen Boyd @ 2014-01-09 18:14 ` Will Deacon 2014-01-09 19:57 ` Stephen Boyd 0 siblings, 1 reply; 6+ messages in thread From: Will Deacon @ 2014-01-09 18:14 UTC (permalink / raw) To: Stephen Boyd Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org On Wed, Jan 08, 2014 at 10:59:43PM +0000, Stephen Boyd wrote: > Document the Krait PMU compatible string. > > Cc: <devicetree@vger.kernel.org> > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> > --- > Documentation/devicetree/bindings/arm/pmu.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/arm/pmu.txt b/Documentation/devicetree/bindings/arm/pmu.txt > index 3e1e498fea96..ce7cccb99d87 100644 > --- a/Documentation/devicetree/bindings/arm/pmu.txt > +++ b/Documentation/devicetree/bindings/arm/pmu.txt > @@ -16,6 +16,7 @@ Required properties: > "arm,arm11mpcore-pmu" > "arm,arm1176-pmu" > "arm,arm1136-pmu" > + "qcom,krait-pmu" > - interrupts : 1 combined interrupt or 1 per core. Might be worth updating the part about interrupts too, given that you've added PPI support. Will ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 6/7] devicetree: bindings: Document Krait performance monitor units (PMU) 2014-01-09 18:14 ` Will Deacon @ 2014-01-09 19:57 ` Stephen Boyd 0 siblings, 0 replies; 6+ messages in thread From: Stephen Boyd @ 2014-01-09 19:57 UTC (permalink / raw) To: Will Deacon Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org On 01/09/14 10:14, Will Deacon wrote: > On Wed, Jan 08, 2014 at 10:59:43PM +0000, Stephen Boyd wrote: >> Document the Krait PMU compatible string. >> >> Cc: <devicetree@vger.kernel.org> >> Signed-off-by: Stephen Boyd <sboyd@codeaurora.org> >> --- >> Documentation/devicetree/bindings/arm/pmu.txt | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/pmu.txt b/Documentation/devicetree/bindings/arm/pmu.txt >> index 3e1e498fea96..ce7cccb99d87 100644 >> --- a/Documentation/devicetree/bindings/arm/pmu.txt >> +++ b/Documentation/devicetree/bindings/arm/pmu.txt >> @@ -16,6 +16,7 @@ Required properties: >> "arm,arm11mpcore-pmu" >> "arm,arm1176-pmu" >> "arm,arm1136-pmu" >> + "qcom,krait-pmu" >> - interrupts : 1 combined interrupt or 1 per core. > Might be worth updating the part about interrupts too, given that you've > added PPI support. Done. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <1389221984-10973-4-git-send-email-sboyd@codeaurora.org>]
[parent not found: <20140109110440.GC17838@mudshark.cambridge.arm.com>]
* Re: [PATCH 3/7] ARM: perf_event: Add basic support for Krait CPU PMUs [not found] ` <20140109110440.GC17838@mudshark.cambridge.arm.com> @ 2014-01-09 19:57 ` Stephen Boyd 2014-01-10 11:01 ` Will Deacon 0 siblings, 1 reply; 6+ messages in thread From: Stephen Boyd @ 2014-01-09 19:57 UTC (permalink / raw) To: Will Deacon Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Neil Leeder, Ashwin Chaugule, devicetree@vger.kernel.org (Adding DT reviewers) On 01/09/14 03:04, Will Deacon wrote: > On Wed, Jan 08, 2014 at 10:59:40PM +0000, Stephen Boyd wrote: > >> +static int krait_pmu_init(struct arm_pmu *cpu_pmu) >> +{ >> + u32 id = read_cpuid_id() & 0xffffff00; >> + >> + armv7pmu_init(cpu_pmu); >> + cpu_pmu->name = "ARMv7 Krait"; >> + /* Some early versions of Krait don't support PC write events */ >> + if (id == 0x511f0400 || id == 0x510f0600) >> + cpu_pmu->map_event = krait_map_event_no_branch; > Hmm, I'd really rather this information came via the DT. In fact, you could > just drop the branch event from your main map_event_function and keep things > simple. It depends how badly you want to advertise it in perf list :) > Not every version of Krait is missing support for this event, so I'd like to keep it so things like perf stat show branch counts. How about I add a bool property to the pmu node indicating that this PMU is missing support for the PC write events? Something like "no-pc-write"? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/7] ARM: perf_event: Add basic support for Krait CPU PMUs 2014-01-09 19:57 ` [PATCH 3/7] ARM: perf_event: Add basic support for Krait CPU PMUs Stephen Boyd @ 2014-01-10 11:01 ` Will Deacon 2014-01-10 18:57 ` Stephen Boyd 0 siblings, 1 reply; 6+ messages in thread From: Will Deacon @ 2014-01-10 11:01 UTC (permalink / raw) To: Stephen Boyd Cc: mark.rutland, devicetree@vger.kernel.org, Ashwin Chaugule, linux-arm-msm@vger.kernel.org, Neil Leeder, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org On Thu, Jan 09, 2014 at 07:57:12PM +0000, Stephen Boyd wrote: > (Adding DT reviewers) > > On 01/09/14 03:04, Will Deacon wrote: > > On Wed, Jan 08, 2014 at 10:59:40PM +0000, Stephen Boyd wrote: > > > >> +static int krait_pmu_init(struct arm_pmu *cpu_pmu) > >> +{ > >> + u32 id = read_cpuid_id() & 0xffffff00; > >> + > >> + armv7pmu_init(cpu_pmu); > >> + cpu_pmu->name = "ARMv7 Krait"; > >> + /* Some early versions of Krait don't support PC write events */ > >> + if (id == 0x511f0400 || id == 0x510f0600) > >> + cpu_pmu->map_event = krait_map_event_no_branch; > > Hmm, I'd really rather this information came via the DT. In fact, you could > > just drop the branch event from your main map_event_function and keep things > > simple. It depends how badly you want to advertise it in perf list :) > > > > Not every version of Krait is missing support for this event, so I'd > like to keep it so things like perf stat show branch counts. How about I > add a bool property to the pmu node indicating that this PMU is missing > support for the PC write events? Something like "no-pc-write"? Perhaps, although I think it should be qualcomm-specific, so something like "qcom,krait-no-pc-write"? Again, I'd be glad to hear something from a DT reviewer on this. Will ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 3/7] ARM: perf_event: Add basic support for Krait CPU PMUs 2014-01-10 11:01 ` Will Deacon @ 2014-01-10 18:57 ` Stephen Boyd 0 siblings, 0 replies; 6+ messages in thread From: Stephen Boyd @ 2014-01-10 18:57 UTC (permalink / raw) To: Will Deacon Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Neil Leeder, Ashwin Chaugule, devicetree@vger.kernel.org, mark.rutland On 01/10, Will Deacon wrote: > On Thu, Jan 09, 2014 at 07:57:12PM +0000, Stephen Boyd wrote: > > (Adding DT reviewers) > > > > On 01/09/14 03:04, Will Deacon wrote: > > > On Wed, Jan 08, 2014 at 10:59:40PM +0000, Stephen Boyd wrote: > > > > > >> +static int krait_pmu_init(struct arm_pmu *cpu_pmu) > > >> +{ > > >> + u32 id = read_cpuid_id() & 0xffffff00; > > >> + > > >> + armv7pmu_init(cpu_pmu); > > >> + cpu_pmu->name = "ARMv7 Krait"; > > >> + /* Some early versions of Krait don't support PC write events */ > > >> + if (id == 0x511f0400 || id == 0x510f0600) > > >> + cpu_pmu->map_event = krait_map_event_no_branch; > > > Hmm, I'd really rather this information came via the DT. In fact, you could > > > just drop the branch event from your main map_event_function and keep things > > > simple. It depends how badly you want to advertise it in perf list :) > > > > > > > Not every version of Krait is missing support for this event, so I'd > > like to keep it so things like perf stat show branch counts. How about I > > add a bool property to the pmu node indicating that this PMU is missing > > support for the PC write events? Something like "no-pc-write"? > > Perhaps, although I think it should be qualcomm-specific, so something like > "qcom,krait-no-pc-write"? Again, I'd be glad to hear something from a DT > reviewer on this. > Yes a vendor prefix is probably a good idea. I'll add that in. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-01-10 18:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1389221984-10973-1-git-send-email-sboyd@codeaurora.org>
[not found] ` <1389221984-10973-1-git-send-email-sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-01-08 22:59 ` [PATCH 6/7] devicetree: bindings: Document Krait performance monitor units (PMU) Stephen Boyd
2014-01-09 18:14 ` Will Deacon
2014-01-09 19:57 ` Stephen Boyd
[not found] ` <1389221984-10973-4-git-send-email-sboyd@codeaurora.org>
[not found] ` <20140109110440.GC17838@mudshark.cambridge.arm.com>
2014-01-09 19:57 ` [PATCH 3/7] ARM: perf_event: Add basic support for Krait CPU PMUs Stephen Boyd
2014-01-10 11:01 ` Will Deacon
2014-01-10 18:57 ` Stephen Boyd
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).