From: Tejun Heo <tj@kernel.org>
To: David Milburn <dmilburn@redhat.com>
Cc: Loc Ho <lho@apm.com>,
olof@lixom.net, arnd@arndb.de, linux-scsi@vger.kernel.org,
linux-ide@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, jcm@redhat.com,
patches@apm.com, Tuan Phan <tphan@apm.com>,
Suman Tripathi <stripathi@apm.com>
Subject: Re: [PATCH v8 3/4] ata: Add APM X-Gene SoC SATA host controller driver
Date: Sat, 11 Jan 2014 14:31:04 -0500 [thread overview]
Message-ID: <20140111193104.GD3257@mtj.dyndns.org> (raw)
In-Reply-To: <52D052F9.8050703@redhat.com>
Hello, David.
On Fri, Jan 10, 2014 at 02:07:21PM -0600, David Milburn wrote:
> Tejun, to avoid some of the interrupt handling code duplication, would
> it better to have a AHCI_HFLAG_FLUSH and then change
>
> this driver to set flush
>
> hpriv->hpriv.flush = (void *) xgene_ahci_iob_flush;
>
> and then standard code flush when necessary
>
> ahci_handle_port_interrupt
>
> /* board-specific flush before servicing completed cmds */
> if (hpriv-> flags & AHCI_HFLAG_FLUSH)
> hpriv->flush(hpriv);
And this would be the only spot that this would be necessary? If so,
why not just wrap the interrupt handler?
Thanks.
--
tejun
next prev parent reply other threads:[~2014-01-11 19:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-06 18:11 [PATCH v8 0/4] ata: Add APM X-Gene SoC SATA host controller support Loc Ho
2014-01-06 18:11 ` [PATCH v8 1/4] ata: Export required functions by APM X-Gene SATA driver Loc Ho
2014-01-06 18:12 ` [PATCH v8 2/4] Documentation: Add documentation for APM X-Gene SoC SATA host controller DTS binding Loc Ho
2014-01-06 18:12 ` [PATCH v8 3/4] ata: Add APM X-Gene SoC SATA host controller driver Loc Ho
2014-01-06 18:12 ` [PATCH v8 4/4] arm64: Add APM X-Gene SoC SATA host controller DTS entries Loc Ho
2014-01-10 19:45 ` [PATCH v8 3/4] ata: Add APM X-Gene SoC SATA host controller driver David Milburn
2014-01-10 20:07 ` David Milburn
2014-01-11 19:31 ` Tejun Heo [this message]
2014-01-12 3:58 ` Loc Ho
2014-01-12 11:49 ` Tejun Heo
2014-01-13 4:01 ` Loc Ho
2014-01-13 16:08 ` Tejun Heo
2014-01-14 15:57 ` Loc Ho
2014-01-14 16:03 ` Tejun Heo
2014-01-14 16:04 ` Tejun Heo
2014-01-14 16:21 ` Loc Ho
2014-01-14 16:30 ` Tejun Heo
[not found] ` <20140114163008.GJ12131-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org>
2014-01-14 16:37 ` Loc Ho
2014-01-14 16:46 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140111193104.GD3257@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=dmilburn@redhat.com \
--cc=jcm@redhat.com \
--cc=lho@apm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=olof@lixom.net \
--cc=patches@apm.com \
--cc=stripathi@apm.com \
--cc=tphan@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).