Re: [PATCH] ARM: sun4i: dt: Add basic board support for LinkSprite pcDuino

[Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 2114 bytes --]

Hi Zoltan,

On Sat, Jan 11, 2014 at 04:54:52PM +0100, Zoltan HERPAI wrote:
> This patch will add a basic board support DT for the
> LinkSprite pcDuino.
> 
> Signed-off-by: Zoltan HERPAI <wigyori-1V5s5g7wVVk@public.gmane.org>
> ---
>  arch/arm/boot/dts/Makefile              |    1 +
>  arch/arm/boot/dts/sun4i-a10-pcduino.dts |   48 +++++++++++++++++++++++++++++++
>  2 files changed, 49 insertions(+), 0 deletions(-)
>  create mode 100644 arch/arm/boot/dts/sun4i-a10-pcduino.dts
> 
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index b663ed7..a2e3620 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -253,6 +253,7 @@ dtb-$(CONFIG_ARCH_SUNXI) += \
>  	sun4i-a10-cubieboard.dtb \
>  	sun4i-a10-mini-xplus.dtb \
>  	sun4i-a10-hackberry.dtb \
> +	sun4i-a10-pcduino.dtb \
>  	sun5i-a10s-olinuxino-micro.dtb \
>  	sun5i-a13-olinuxino.dtb \
>  	sun5i-a13-olinuxino-micro.dtb \
> diff --git a/arch/arm/boot/dts/sun4i-a10-pcduino.dts b/arch/arm/boot/dts/sun4i-a10-pcduino.dts
> new file mode 100644
> index 0000000..752f002
> --- /dev/null
> +++ b/arch/arm/boot/dts/sun4i-a10-pcduino.dts
> @@ -0,0 +1,48 @@
> +/*
> + * Copyright 2014 Zoltan HERPAI
> + * Zoltan HERPAI <wigyori-1V5s5g7wVVk@public.gmane.org>
> + *
> + * The code contained herein is licensed under the GNU General Public
> + * License. You may obtain a copy of the GNU General Public License
> + * Version 2 or later at the following locations:
> + *
> + * http://www.opensource.org/licenses/gpl-license.html
> + * http://www.gnu.org/copyleft/gpl.html
> + */
> +
> +/dts-v1/;
> +/include/ "sun4i-a10.dtsi"
> +
> +/ {
> +	model = "LinkSprite pcDuino";
> +	compatible = "pcduino,a10-pcduino", "allwinner,sun4i-a10";

Is LinkSprite the retailer or the manufacturer?

If the former, it shouldn't appear in the model string, if the latter,
it should be the prefix in the compatible.

Otherwise, it looks very good, thanks!

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]