From mboxrd@z Thu Jan 1 00:00:00 1970 From: Felipe Balbi Subject: Re: [PATCHv4 6/7] hwspinlock/omap: enable module before reading SYSSTATUS register Date: Tue, 14 Jan 2014 08:04:40 -0600 Message-ID: <20140114140440.GA15785@saruman.home> References: <1389658764-39199-1-git-send-email-s-anna@ti.com> <1389658764-39199-7-git-send-email-s-anna@ti.com> <20140114131052.GA10818@saruman.home> Reply-To: Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="mP3DRpeJDSE+ciuQ" Return-path: Content-Disposition: inline In-Reply-To: <20140114131052.GA10818@saruman.home> Sender: linux-omap-owner@vger.kernel.org To: Felipe Balbi Cc: Suman Anna , Ohad Ben-Cohen , Mark Rutland , Tony Lindgren , Kumar Gala , linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org --mP3DRpeJDSE+ciuQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi again, On Tue, Jan 14, 2014 at 07:10:52AM -0600, Felipe Balbi wrote: > > diff --git a/drivers/hwspinlock/omap_hwspinlock.c b/drivers/hwspinlock/= omap_hwspinlock.c > > index 9f56fb2..194886e 100644 > > --- a/drivers/hwspinlock/omap_hwspinlock.c > > +++ b/drivers/hwspinlock/omap_hwspinlock.c > > @@ -101,10 +101,23 @@ static int omap_hwspinlock_probe(struct platform_= device *pdev) > > if (!io_base) > > return -ENOMEM; > > =20 > > + /* > > + * make sure the module is enabled and clocked before reading > > + * the module SYSSTATUS register > > + */ > > + pm_runtime_enable(&pdev->dev); > > + pm_runtime_get_sync(&pdev->dev); another thing, you need to check return of pm_runtime_get_sync() --=20 balbi --mP3DRpeJDSE+ciuQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJS1UP3AAoJEIaOsuA1yqRElJUP/1F/oueJnqaGY9iM1/c5pe7y /nEliOv45s/+Xm+j8G0oau9eN002nbN83btf5t8w89Tbkntp9hR8kuKh1YdgX3NO 7lgHT1EE4HkyQSsI8+XnBEhZVnIehnbBaExeFu7UIxY/BtA84aZ4qhVQuA2AfTMG HlxCCGv+pwIW5xrwiS2WkByNXlD9L72YHmqZHyzl/B4HbYjbcvkfwh1/LN1TCD21 Kat9RVwAoUPgp7xD61JIO0ig6I+O73HRzW2Xjbj89j9gs1hVLTBEKNElxgg7LhcH vsPQhynShlZwNQN2iAQP9MPXVIVpb5ZI2RpWjJS26ai8B2G38sV7q95ILVrkgLTK T6wAgnEMjTysE67r544lvzi9QEGaAGYPOnl2M8EBnqVlxLuNh2POwBeTpGJJrQUh s5TFG3XD0zj6OVcpusQwrrnF4XUk2FLXxQePkmaPADJTMBnqD5g/QZnl9VfVEj7B 0ICbmYhzODgKhdQtkIJFdstdwPSL0BmkHKkCLxc68Za34WVYFGbLeVYR/XuUt5U8 AJKcA7MyC+vg/jKUL13qaYm7KwdmkZRkLtBT/KG90A2jEwygckrWn/pDNT66RjhS ukVrLw3TQEd+6Nnp+MRHV+ANJhHMzxtlF3Z97N3seckON7Wrt4SqaOsnwqII+A10 xMGT+/pN+qjO/X93kwEC =tdmP -----END PGP SIGNATURE----- --mP3DRpeJDSE+ciuQ--