From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: Re: [PATCH v8 3/4] ata: Add APM X-Gene SoC SATA host controller driver Date: Tue, 14 Jan 2014 11:04:19 -0500 Message-ID: <20140114160419.GI12131@htj.dyndns.org> References: <1389031922-4309-3-git-send-email-lho@apm.com> <1389031922-4309-4-git-send-email-lho@apm.com> <52D052F9.8050703@redhat.com> <20140111193104.GD3257@mtj.dyndns.org> <6EB44142-06DA-4C9D-8999-CFA9EE30E03D@apm.com> <20140112114958.GA8509@mtj.dyndns.org> <20140113160843.GB29053@htj.dyndns.org> <20140114160312.GH12131@htj.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20140114160312.GH12131@htj.dyndns.org> Sender: linux-scsi-owner@vger.kernel.org To: Loc Ho Cc: David Milburn , "olof@lixom.net" , "arnd@arndb.de" , "linux-scsi@vger.kernel.org" , "linux-ide@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "jcm@redhat.com" , "patches@apm.com" , Tuan Phan , Suman Tripathi List-Id: devicetree@vger.kernel.org On Tue, Jan 14, 2014 at 11:03:12AM -0500, Tejun Heo wrote: > > As mentioned, the flush requires immediately after reading the CI. > > Otherwise, there is still an chance that the command is completed and > > the OS notified the upper layer while the data is still in flight. For > > the initial version, I will remove the flush (IRQ wrapper) and submit > > separate patch. > > The function is called with ap->lock held. Nothing can happen > inbetween. Oh, or do you mean that upper layer may get data which hasn't finish transferring without the flush? -- tejun