From: Arnd Bergmann <arnd@arndb.de>
To: Jingchang Lu <b35083@freescale.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
pawel.moll@arm.com, swarren@wwwdotorg.org, vinod.koul@intel.com,
Alison Wang <b18965@freescale.com>,
linux-kernel@vger.kernel.org, dan.j.williams@intel.com,
shawn.guo@linaro.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCHv9 2/2] dma: Add Freescale eDMA engine driver support
Date: Thu, 16 Jan 2014 12:02:48 +0100 [thread overview]
Message-ID: <201401161202.49333.arnd@arndb.de> (raw)
In-Reply-To: <1389839400-29728-3-git-send-email-b35083@freescale.com>
On Thursday 16 January 2014, Jingchang Lu wrote:
> Add Freescale enhanced direct memory(eDMA) controller support.
> This module can be found on Vybrid and LS-1 SoCs.
>
> Signed-off-by: Alison Wang <b18965@freescale.com>
> Signed-off-by: Jingchang Lu <b35083@freescale.com>
Very nice! All my previous comments have been addressed, so
Acked-by: Arnd Bergmann <arnd@arndb.de>
One small comment still:
> +
> +static DEFINE_MUTEX(fsl_edma_mutex);
> +
I think this mutex should be part of struct fsl_edma_engine, not global.
Arnd
next prev parent reply other threads:[~2014-01-16 11:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-16 2:29 [PATCHv9 0/2] dma: Add Freescale eDMA engine driver support Jingchang Lu
2014-01-16 2:29 ` [PATCHv9 1/2] ARM: dts: vf610: Add eDMA node Jingchang Lu
2014-01-16 2:30 ` [PATCHv9 2/2] dma: Add Freescale eDMA engine driver support Jingchang Lu
2014-01-16 11:02 ` Arnd Bergmann [this message]
2014-01-17 2:22 ` Jingchang Lu
2014-01-16 11:12 ` Mark Rutland
2014-01-17 2:58 ` Jingchang Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201401161202.49333.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=b18965@freescale.com \
--cc=b35083@freescale.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=shawn.guo@linaro.org \
--cc=swarren@wwwdotorg.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).