Re: [PATCH v5 00/14] Add support for MSM's mmio clock/reset controller

[Mike Turquette <mturquette@linaro.org>]

Quoting Stephen Boyd (2014-01-15 10:47:20)
> The first breaks a reset-controller include ordering requirement. It got
> an ack so I think we're ok for it to go through the clock tree.
> 
> The next patch adds support for setting the rate and the parent at the
> same time based on patches from James Hogan's remuxing set_rate series.
> 
> After that we add MSM clock hardware support and SoC specific drivers. The DT
> node additions will be sent through the MSM maintainers once these patches are
> accepted.

Hi Stephen,

These patches look great and I've taken them into clk-next for testing.
They should get pushed out to my Linaro mirror later today and will go
in for 3.14. Thanks for spinning the revisions to this series so
quickly.

There might still be some way to share the regmap helpers in the future,
and getting these patches merged is a good starting point.

Regards,
Mike

> 
> Changes since v4:
>  * Moved regmap code out of the core into drivers/clk/qcom/
>  * Reworked to use a wrapper clk_regmap struct
> 
> Changes since v3:
>  * Moved binding include to clock/
>  * New patch for 8660 GCC driver
>  * Renamed directory to qcom to match vendor prefix
>  * Added some missing clocks in 8974 GCC driver
>  * New patch for 8974 MMCC driver
> 
> Changes since v2:
> 
>  * Completed 8960 and 8974 GCC data & dt-bindings
>  * Added support for reset controllers
>  * Squashed some bugs in 8974 gcc clocks
>  * New patch to fix clk NULL pointer deref
>  * New patch to fix #include requirement for reset-controller.h
> 
> Changes since v1:
> 
>  * Rewrote binding to use #clock-cells=1
>  * Reworked library components (pll, rcg, branch) to use regmap
>  * Dropped common clock framework patches that did DT parsing
>  * New patches for regmap support in common clock framework
> 
> Stephen Boyd (14):
>   reset: Silence warning in reset-controller.h
>   clk: Add set_rate_and_parent() op
>   clk: qcom: Add a regmap type clock struct
>   clk: qcom: Add support for phase locked loops (PLLs)
>   clk: qcom: Add support for root clock generators (RCGs)
>   clk: qcom: Add support for branches/gate clocks
>   clk: qcom: Add reset controller support
>   clk: qcom: Add support for MSM8960's global clock controller (GCC)
>   clk: qcom: Add support for MSM8960's multimedia clock controller
>     (MMCC)
>   clk: qcom: Add support for MSM8974's global clock controller (GCC)
>   clk: qcom: Add support for MSM8974's multimedia clock controller
>     (MMCC)
>   clk: qcom: Add support for MSM8660's global clock controller (GCC)
>   devicetree: bindings: Document qcom,gcc
>   devicetree: bindings: Document qcom,mmcc
> 
>  Documentation/clk.txt                              |    3 +
>  .../devicetree/bindings/clock/qcom,gcc.txt         |   21 +
>  .../devicetree/bindings/clock/qcom,mmcc.txt        |   21 +
>  drivers/clk/Kconfig                                |    2 +
>  drivers/clk/Makefile                               |    1 +
>  drivers/clk/clk.c                                  |   78 +-
>  drivers/clk/qcom/Kconfig                           |   47 +
>  drivers/clk/qcom/Makefile                          |   14 +
>  drivers/clk/qcom/clk-branch.c                      |  159 ++
>  drivers/clk/qcom/clk-branch.h                      |   56 +
>  drivers/clk/qcom/clk-pll.c                         |  222 ++
>  drivers/clk/qcom/clk-pll.h                         |   66 +
>  drivers/clk/qcom/clk-rcg.c                         |  517 ++++
>  drivers/clk/qcom/clk-rcg.h                         |  159 ++
>  drivers/clk/qcom/clk-rcg2.c                        |  291 ++
>  drivers/clk/qcom/clk-regmap.c                      |  114 +
>  drivers/clk/qcom/clk-regmap.h                      |   45 +
>  drivers/clk/qcom/gcc-msm8660.c                     | 2819 ++++++++++++++++++
>  drivers/clk/qcom/gcc-msm8960.c                     | 2993 ++++++++++++++++++++
>  drivers/clk/qcom/gcc-msm8974.c                     | 2694 ++++++++++++++++++
>  drivers/clk/qcom/mmcc-msm8960.c                    | 2321 +++++++++++++++
>  drivers/clk/qcom/mmcc-msm8974.c                    | 2625 +++++++++++++++++
>  drivers/clk/qcom/reset.c                           |   63 +
>  drivers/clk/qcom/reset.h                           |   37 +
>  include/dt-bindings/clock/qcom,gcc-msm8660.h       |  276 ++
>  include/dt-bindings/clock/qcom,gcc-msm8960.h       |  313 ++
>  include/dt-bindings/clock/qcom,gcc-msm8974.h       |  320 +++
>  include/dt-bindings/clock/qcom,mmcc-msm8960.h      |  137 +
>  include/dt-bindings/clock/qcom,mmcc-msm8974.h      |  161 ++
>  include/dt-bindings/reset/qcom,gcc-msm8660.h       |  134 +
>  include/dt-bindings/reset/qcom,gcc-msm8960.h       |  118 +
>  include/dt-bindings/reset/qcom,gcc-msm8974.h       |   96 +
>  include/dt-bindings/reset/qcom,mmcc-msm8960.h      |   93 +
>  include/dt-bindings/reset/qcom,mmcc-msm8974.h      |   62 +
>  include/linux/clk-provider.h                       |   15 +
>  include/linux/reset-controller.h                   |    1 +
>  36 files changed, 17075 insertions(+), 19 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/clock/qcom,gcc.txt
>  create mode 100644 Documentation/devicetree/bindings/clock/qcom,mmcc.txt
>  create mode 100644 drivers/clk/qcom/Kconfig
>  create mode 100644 drivers/clk/qcom/Makefile
>  create mode 100644 drivers/clk/qcom/clk-branch.c
>  create mode 100644 drivers/clk/qcom/clk-branch.h
>  create mode 100644 drivers/clk/qcom/clk-pll.c
>  create mode 100644 drivers/clk/qcom/clk-pll.h
>  create mode 100644 drivers/clk/qcom/clk-rcg.c
>  create mode 100644 drivers/clk/qcom/clk-rcg.h
>  create mode 100644 drivers/clk/qcom/clk-rcg2.c
>  create mode 100644 drivers/clk/qcom/clk-regmap.c
>  create mode 100644 drivers/clk/qcom/clk-regmap.h
>  create mode 100644 drivers/clk/qcom/gcc-msm8660.c
>  create mode 100644 drivers/clk/qcom/gcc-msm8960.c
>  create mode 100644 drivers/clk/qcom/gcc-msm8974.c
>  create mode 100644 drivers/clk/qcom/mmcc-msm8960.c
>  create mode 100644 drivers/clk/qcom/mmcc-msm8974.c
>  create mode 100644 drivers/clk/qcom/reset.c
>  create mode 100644 drivers/clk/qcom/reset.h
>  create mode 100644 include/dt-bindings/clock/qcom,gcc-msm8660.h
>  create mode 100644 include/dt-bindings/clock/qcom,gcc-msm8960.h
>  create mode 100644 include/dt-bindings/clock/qcom,gcc-msm8974.h
>  create mode 100644 include/dt-bindings/clock/qcom,mmcc-msm8960.h
>  create mode 100644 include/dt-bindings/clock/qcom,mmcc-msm8974.h
>  create mode 100644 include/dt-bindings/reset/qcom,gcc-msm8660.h
>  create mode 100644 include/dt-bindings/reset/qcom,gcc-msm8960.h
>  create mode 100644 include/dt-bindings/reset/qcom,gcc-msm8974.h
>  create mode 100644 include/dt-bindings/reset/qcom,mmcc-msm8960.h
>  create mode 100644 include/dt-bindings/reset/qcom,mmcc-msm8974.h
> 
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> hosted by The Linux Foundation
>