From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ezequiel Garcia Subject: Re: [PATCH v2 03/15] watchdog: orion: Use atomic access for shared registers Date: Tue, 21 Jan 2014 06:42:15 -0300 Message-ID: <20140121094214.GA3577@localhost> References: <1390295561-3466-1-git-send-email-ezequiel.garcia@free-electrons.com> <1390295561-3466-4-git-send-email-ezequiel.garcia@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Fabio Estevam Cc: "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Wim Van Sebroeck , Gregory Clement , Lior Amsalem , Tawfik Bayouk , Thomas Petazzoni , Jason Cooper , Sebastian Hesselbarth , Jason Gunthorpe , Andrew Lunn List-Id: devicetree@vger.kernel.org On Tue, Jan 21, 2014 at 07:19:52AM -0200, Fabio Estevam wrote: > On Tue, Jan 21, 2014 at 7:12 AM, Ezequiel Garcia > wrote: > > Since the timer control register is shared with the clocksource dri= ver, > > use the recently introduced atomic_io_clear_set() to access such re= gister. > > > > Signed-off-by: Ezequiel Garcia > > --- > > drivers/watchdog/orion_wdt.c | 20 ++++---------------- > > 1 file changed, 4 insertions(+), 16 deletions(-) > > > > diff --git a/drivers/watchdog/orion_wdt.c b/drivers/watchdog/orion_= wdt.c > > index f7722a4..cf64510 100644 > > --- a/drivers/watchdog/orion_wdt.c > > +++ b/drivers/watchdog/orion_wdt.c > > @@ -61,8 +61,6 @@ static int orion_wdt_ping(struct watchdog_device = *wdt_dev) > > > > static int orion_wdt_start(struct watchdog_device *wdt_dev) > > { > > - u32 reg; > > - > > spin_lock(&wdt_lock); >=20 > Shouldn't this spin_lock be dropped now? >=20 Hm... yes. The watchdog core uses a mutex to serialize all the watchdog= hooks: start, stop, ping, set_timeout, etc. So it seems you're right, the spin= lock should be dropped entirely as I see no need for it. Thanks for the feedback, --=20 Ezequiel Garc=C3=ADa, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html