From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ezequiel Garcia Subject: Re: [PATCH v2 09/15] watchdog: orion: Add per-compatible clock initialization Date: Tue, 21 Jan 2014 06:43:14 -0300 Message-ID: <20140121094313.GB3577@localhost> References: <1390295561-3466-1-git-send-email-ezequiel.garcia@free-electrons.com> <1390295561-3466-10-git-send-email-ezequiel.garcia@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Fabio Estevam Cc: "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Wim Van Sebroeck , Gregory Clement , Lior Amsalem , Tawfik Bayouk , Thomas Petazzoni , Jason Cooper , Sebastian Hesselbarth , Jason Gunthorpe , Andrew Lunn List-Id: devicetree@vger.kernel.org On Tue, Jan 21, 2014 at 07:18:44AM -0200, Fabio Estevam wrote: > On Tue, Jan 21, 2014 at 7:12 AM, Ezequiel Garcia > wrote: >=20 > > +static int orion_wdt_clock_init(struct platform_device *pdev, > > + struct orion_watchdog *dev) > > +{ > > + dev->clk =3D devm_clk_get(&pdev->dev, NULL); > > + if (IS_ERR(dev->clk)) > > + return -ENODEV; >=20 > Shouldn't it be 'return PTR_ERR(dev->clk)' instead? >=20 >=20 [..] > > + clk_prepare_enable(dev->clk); >=20 > clk_prepare_enable may fail, so better check its return value. >=20 Indeed. Thanks! --=20 Ezequiel Garc=C3=ADa, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html