From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ezequiel Garcia Subject: Re: [PATCH v2 05/15] watchdog: orion: Make RSTOUT register a separate resource Date: Wed, 22 Jan 2014 13:21:37 -0300 Message-ID: <20140122162136.GA27273@localhost> References: <1390295561-3466-1-git-send-email-ezequiel.garcia@free-electrons.com> <1390295561-3466-6-git-send-email-ezequiel.garcia@free-electrons.com> <20140121233321.GR18269@obsidianresearch.com> <3176358.2QFcJHj0fv@wuerfel> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <3176358.2QFcJHj0fv@wuerfel> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Arnd Bergmann , Jason Gunthorpe Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Lior Amsalem , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Tawfik Bayouk , Andrew Lunn , Wim Van Sebroeck , Gregory Clement , Sebastian Hesselbarth , Thomas Petazzoni , Jason Cooper List-Id: devicetree@vger.kernel.org Jason, Arnd: On Wed, Jan 22, 2014 at 10:48:37AM +0100, Arnd Bergmann wrote: > On Tuesday 21 January 2014 16:33:21 Jason Gunthorpe wrote: > > On Tue, Jan 21, 2014 at 06:12:31AM -0300, Ezequiel Garcia wrote: > > > In order to support other SoC, it's required to distinguish > > > the 'control' timer register, from the 'rstout' register > > > that enables system reset on watchdog expiration. > >=20 > > > + res =3D platform_get_resource(pdev, IORESOURCE_MEM, 1); > > > + if (!res) > > > + return -ENODEV; > > ^^^^^^^^^^^^^^^^^^^^^^ > >=20 > > This change seems to break compatibility with existing DT files tha= t > > have only a single entry in reg? > >=20 > > Can the value be defaulted some how if missing? >=20 > I think this is a direct consequence of the attempt to remove the > header file dependency, since the RSTOUTn_MASK macro is defined > in mach/bridge-regs.h. >=20 Exactly. Just for the record, I warned about this a while back: http://www.spinics.net/lists/arm-kernel/msg270163.html That said, it truly sucks to break compatibility so finding a way to keep backwards compatibility would be certainly desirable. > I don't see a good way out that would preserve backwards compatibilit= y, > other than hardcoding the physical address in the driver, which seems > just as bad as breaking compatibility. That said, it is always the > same constant (0xf1000000 + 0x20000 + 0x0108) on Dove, Kirkwood and > Orion5x (not on mv78xx0, but that doesn't use the wdt), so hardcoding > a fallback would technically work, but we should print a fat warning = at > boot time if we actually fall back to that. >=20 Yes, I was thinking just about this. Namely: If the second resource is missing *and* the compatible-string is "orion-watchdog" (or it's not DT-registered), then use a hardcoded RSTOUTn_MASK address. And pr_warn() something. Thanks for the feedback, --=20 Ezequiel Garc=C3=ADa, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html