From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ezequiel Garcia Subject: Re: [PATCH v2 05/15] watchdog: orion: Make RSTOUT register a separate resource Date: Wed, 22 Jan 2014 15:29:15 -0300 Message-ID: <20140122182914.GH27273@localhost> References: <1390295561-3466-1-git-send-email-ezequiel.garcia@free-electrons.com> <1390295561-3466-6-git-send-email-ezequiel.garcia@free-electrons.com> <20140121233321.GR18269@obsidianresearch.com> <3176358.2QFcJHj0fv@wuerfel> <20140122162136.GA27273@localhost> <20140122180100.GE27273@localhost> <20140122181409.GV18269@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <20140122181409.GV18269-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jason Gunthorpe Cc: Arnd Bergmann , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Lior Amsalem , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Tawfik Bayouk , Andrew Lunn , Wim Van Sebroeck , Gregory Clement , Sebastian Hesselbarth , Thomas Petazzoni , Jason Cooper List-Id: devicetree@vger.kernel.org On Wed, Jan 22, 2014 at 11:14:09AM -0700, Jason Gunthorpe wrote: > On Wed, Jan 22, 2014 at 03:01:01PM -0300, Ezequiel Garcia wrote: > > On Wed, Jan 22, 2014 at 01:21:36PM -0300, Ezequiel Garcia wrote: > > > > I don't see a good way out that would preserve backwards compat= ibility, > > > > other than hardcoding the physical address in the driver, which= seems > > > > just as bad as breaking compatibility. That said, it is always = the > > > > same constant (0xf1000000 + 0x20000 + 0x0108) on Dove, Kirkwood= and > > > > Orion5x (not on mv78xx0, but that doesn't use the wdt), so hard= coding > > > > a fallback would technically work, but we should print a fat wa= rning at > > > > boot time if we actually fall back to that. > > > >=20 > > >=20 > > > Yes, I was thinking just about this. Namely: > > >=20 > > [..] > >=20 > > How about something like this? >=20 > I liked Arnd's idea to use an offset from the first register. With th= e > mbus driver we can now actually change the 0xF1.. prefix via the DT. >=20 Good idea. Maybe extracting the base address from the timer control register: wdt_reg & 0xff000000 ? --=20 Ezequiel Garc=C3=ADa, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html