From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonas Gorski Subject: Re: [PATCH 2/2] ehci-platform: Add support for controllers with big-endian regs / descriptors Date: Thu, 23 Jan 2014 00:03:30 +0100 Message-ID: <20140123000330.00002567@openwrt.org> References: <20140122213434.00000f25@openwrt.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alan Stern Cc: Hans de Goede , Florian Fainelli , devicetree , linux-usb , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org On Wed, 22 Jan 2014 16:17:42 -0500 (EST) Alan Stern wrote: > On Wed, 22 Jan 2014, Jonas Gorski wrote: > > > If it's safe to set ehci->big_endian_{desc,mmio} from the _probe() > > routine, then maybe the pdata sets in _reset() should be moved into here > > instead of adding extra cludges/checks into _reset(). > > Why? What difference would it make? Effectivewise none, but to me it seems to be cleaner to set them once in probe() instead of everytime reset() is called. I admit I don't know the code flow good enough if reset() is called more than once in the lifetime of a hcd device. And as I said, it would allow doing the checks the patch adds for both DT and !DT, not just DT only. Regards Jonas -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html