From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ezequiel Garcia Subject: Re: [PATCH v2 06/15] watchdog: orion: Remove unneeded BRIDGE_CAUSE clear Date: Thu, 23 Jan 2014 08:10:51 -0300 Message-ID: <20140123111049.GB6065@localhost> References: <1390295561-3466-1-git-send-email-ezequiel.garcia@free-electrons.com> <1390295561-3466-7-git-send-email-ezequiel.garcia@free-electrons.com> <20140121233537.GS18269@obsidianresearch.com> <20140122164904.GB27273@localhost> <20140122173417.GT18269@obsidianresearch.com> <52E02AB6.7040104@gmail.com> <20140122205213.GW18269@obsidianresearch.com> <52E0591E.6030009@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <52E0591E.6030009-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sebastian Hesselbarth Cc: Jason Gunthorpe , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Lior Amsalem , Thomas Petazzoni , Jason Cooper , Tawfik Bayouk , Andrew Lunn , Wim Van Sebroeck , Gregory Clement List-Id: devicetree@vger.kernel.org On Thu, Jan 23, 2014 at 12:49:50AM +0100, Sebastian Hesselbarth wrote: [..] > > Notice that Ezequiel has added an IRQ handler that just calls panic= , > > so a spurious interrupt call is VERY VERY BAD. >=20 > And I understand that he now clears watchdog's register before > requesting an irq. All that is missing is bridge_irq driver clearing > CAUSE register after masking all irqs, right? >=20 Are you sure clearing the CAUSE register after masking the IRQs will be= enough? AFAICS, until now nobody unmasks the watchdog IRQ (at least the orion_w= dt driver didn't request the interruption) but *still* the CAUSE register = is set upon watchdog expiration. So I would guessed a masked interrupt still r= aises a bit in the CAUSE register. Although I'm no sure I'm making sense here or just noise... --=20 Ezequiel Garc=C3=ADa, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html