From: Mark Rutland <mark.rutland@arm.com>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: Naveen Krishna Chatradhi <ch.naveen@samsung.com>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"vzapolskiy@gmail.com" <vzapolskiy@gmail.com>,
"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
"naveenkrishna.ch@gmail.com" <naveenkrishna.ch@gmail.com>,
"cpgs@samsung.com" <cpgs@samsung.com>,
"tomasz.figa@gmail.com" <tomasz.figa@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
devicetree <devicetree@vger.kernel.org>
Subject: Re: [PATCH 2/8 v4] crypto:s5p-sss: Add device tree support
Date: Thu, 23 Jan 2014 17:59:30 +0000 [thread overview]
Message-ID: <20140123175930.GJ15586@e106331-lin.cambridge.arm.com> (raw)
In-Reply-To: <52E155AD.9070802@samsung.com>
On Thu, Jan 23, 2014 at 05:47:25PM +0000, Sylwester Nawrocki wrote:
> On 23/01/14 18:41, Mark Rutland wrote:
> >>> diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
> >>> > > index 93cddeb..2da5617 100644
> >>> > > --- a/drivers/crypto/s5p-sss.c
> >>> > > +++ b/drivers/crypto/s5p-sss.c
> >>> > > @@ -22,6 +22,7 @@
> >>> > > #include <linux/scatterlist.h>
> >>> > > #include <linux/dma-mapping.h>
> >>> > > #include <linux/io.h>
> >>> > > +#include <linux/of.h>
> >>> > > #include <linux/crypto.h>
> >>> > > #include <linux/interrupt.h>
> >>> > >
> >>> > > @@ -177,6 +178,12 @@ struct s5p_aes_dev {
> >>> > >
> >>> > > static struct s5p_aes_dev *s5p_dev;
> >>> > >
> >>> > > +static const struct of_device_id s5p_sss_dt_match[] = {
> >>> > > + { .compatible = "samsung,s5pv210-secss", },
> >> >
> >> > nit: the first semicolon could be omitted.
> >
> > I assume you mean comma ratehr than semicolon?
>
> Indeed...and it's actually the second one :-/
Also, I meant "rather" rather than "ratehr". At least we figured it out
in the end. :)
Thanks,
Mark.
next prev parent reply other threads:[~2014-01-23 17:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1389243541-13122-1-git-send-email-ch.naveen@samsung.com>
[not found] ` <1389777291-15026-1-git-send-email-ch.naveen@samsung.com>
2014-01-23 10:28 ` [PATCH 2/8 v4] crypto:s5p-sss: Add device tree support Sylwester Nawrocki
2014-01-23 17:41 ` Mark Rutland
2014-01-23 17:47 ` Sylwester Nawrocki
2014-01-23 17:59 ` Mark Rutland [this message]
2014-01-29 9:20 ` [PATCH 2/9 v5] " Naveen Krishna Chatradhi
2014-02-06 14:36 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140123175930.GJ15586@e106331-lin.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=ch.naveen@samsung.com \
--cc=cpgs@samsung.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=naveenkrishna.ch@gmail.com \
--cc=s.nawrocki@samsung.com \
--cc=tomasz.figa@gmail.com \
--cc=vzapolskiy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).