From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Subject: Re: [PATCH v4 07/18] watchdog: orion: Handle IRQ Date: Sun, 26 Jan 2014 15:57:51 +0100 Message-ID: <20140126155751.6c6ea59d@skate> References: <1390431915-5115-1-git-send-email-ezequiel.garcia@free-electrons.com> <1390431915-5115-8-git-send-email-ezequiel.garcia@free-electrons.com> <20140126090412.37f4932f@skate> <20140126131445.GA14713@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20140126131445.GA14713@localhost> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ezequiel Garcia Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Wim Van Sebroeck , Jason Gunthorpe , Sebastian Hesselbarth , Arnd Bergmann , Daniel Lezcano , Fabio Estevam , Andrew Lunn , Gregory Clement , Tawfik Bayouk , Lior Amsalem , Guenter Roeck , Jason Cooper List-Id: devicetree@vger.kernel.org Dear Ezequiel Garcia, On Sun, 26 Jan 2014 10:14:46 -0300, Ezequiel Garcia wrote: > > I don't quiite understand the first sentence of this commit log, and > > the commit title looks wrong. Maybe a bad copy/paste or something? > > > > Hm... yes it doesn't look right. It should read: > > "DT-enabled platforms, where the irqchip driver for the brigde interrupt > controller is available, can handle the watchdog IRQ properly. Therefore, > we request the interrupt and add a dummy handler that merely calls panic()". Ok. > I guess we can re-phrase it be a bit more readable. > > Why does th commit title looks wrong? By requesting the IRQ we are > "handling it", no? Right, but it looks "truncated". Maybe something like: watchdog: orion: handle irq to avoid having to clear BRIDGE_CLAUSE or something like that (adjust to the actual reality, I haven't followed all the implications). Thomas -- Thomas Petazzoni, CTO, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html