From: Mark Brown <broonie@kernel.org>
To: Markus Pargmann <mpa@pengutronix.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
Lars-Peter Clausen <lars@metafoo.de>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
kernel@pengutronix.de, Kumar Gala <galak@codeaurora.org>
Subject: Re: [PATCH v3 5/6] ASoC: tlv320aic32x4: Support for master clock
Date: Mon, 27 Jan 2014 18:17:07 +0000 [thread overview]
Message-ID: <20140127181707.GD11841@sirena.org.uk> (raw)
In-Reply-To: <1390824190-18376-6-git-send-email-mpa@pengutronix.de>
[-- Attachment #1.1: Type: text/plain, Size: 501 bytes --]
On Mon, Jan 27, 2014 at 01:03:09PM +0100, Markus Pargmann wrote:
> case SND_SOC_BIAS_STANDBY:
> + /* Switch off master clock */
> + if (!IS_ERR(aic32x4->mclk))
> + clk_disable_unprepare(aic32x4->mclk);
> +
> /* Switch off PLL */
> snd_soc_update_bits(codec, AIC32X4_PLLPR,
> AIC32X4_PLLEN, 0);
This looks like it's disabling the MCLK before disabling the PLL - if
the two are being disabled together I would expect to see the other way
around.
Otherwise this looks good to me.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2014-01-27 18:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1390824190-18376-1-git-send-email-mpa@pengutronix.de>
[not found] ` <1390824190-18376-1-git-send-email-mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-01-27 12:03 ` [PATCH v3 4/6] ASoC: tlv320aic32x4: DT support Markus Pargmann
[not found] ` <1390824190-18376-5-git-send-email-mpa-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2014-02-03 12:48 ` Mark Brown
2014-01-27 12:03 ` [PATCH v3 5/6] ASoC: tlv320aic32x4: Support for master clock Markus Pargmann
2014-01-27 18:17 ` Mark Brown [this message]
2014-01-28 10:01 ` Markus Pargmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140127181707.GD11841@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pengutronix.de \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=mark.rutland@arm.com \
--cc=mpa@pengutronix.de \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).