From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ezequiel Garcia Subject: Re: [RFC PATCH v2 03/14] of: mtd: add documentation for nand-ecc-level property Date: Wed, 29 Jan 2014 14:53:32 -0300 Message-ID: <20140129175331.GA27143@localhost> References: <1391006064-28890-1-git-send-email-b.brezillon.dev@gmail.com> <1391006064-28890-4-git-send-email-b.brezillon.dev@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1391006064-28890-4-git-send-email-b.brezillon.dev@gmail.com> Sender: linux-doc-owner@vger.kernel.org To: Boris BREZILLON Cc: Maxime Ripard , Rob Landley , Russell King , David Woodhouse , Grant Likely , Brian Norris , Jason Gunthorpe , Arnd Bergmann , devicetree@vger.kernel.org, linux-doc@vger.kernel.org, dev@linux-sunxi.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Pekon Gupta List-Id: devicetree@vger.kernel.org On Wed, Jan 29, 2014 at 03:34:13PM +0100, Boris BREZILLON wrote: > nand-ecc-level property statically defines NAND chip's ECC requiremen= ts. >=20 > Signed-off-by: Boris BREZILLON > --- > Documentation/devicetree/bindings/mtd/nand.txt | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/mtd/nand.txt b/Documen= tation/devicetree/bindings/mtd/nand.txt > index 03855c8..0c962296 100644 > --- a/Documentation/devicetree/bindings/mtd/nand.txt > +++ b/Documentation/devicetree/bindings/mtd/nand.txt > @@ -3,5 +3,8 @@ > - nand-ecc-mode : String, operation mode of the NAND ecc mode. > Supported values are: "none", "soft", "hw", "hw_syndrome", "hw_oob= _first", > "soft_bch". > +- nand-ecc-level : Two cells property defining the ECC level require= ments. > + The first cell represent the strength and the second cell the ECC = block size. > + E.g. : nand-ecc-level =3D <4 512>; /* 4 bits / 512 bytes */ > - nand-bus-width : 8 or 16 bus width if not present 8 > - nand-on-flash-bbt: boolean to enable on flash bbt option if not pr= esent false Hm.. when was this proposal agreed? It seems I've missed the discussion... =46WIW, we've already proposed an equivalent one, but it received no feedback from the devicetree maintainers: http://comments.gmane.org/gmane.linux.drivers.devicetree/58764 Maybe we can discuss about it now? nand-ecc-strength : integer ECC required strength. nand-ecc-size : integer step size associated to the ECC strength. vs. nand-ecc-level : Two cells property defining the ECC level requiremen= ts. The first cell represent the strength and the second cell the ECC blo= ck size. E.g. : nand-ecc-level =3D <4 512>; /* 4 bits / 512 bytes */ It's really the same proposal but with a different format, right? IMHO, the former is more human-readable, but other than that I see no difference. Brian? DT-guys? --=20 Ezequiel Garc=C3=ADa, Free Electrons Embedded Linux, Kernel and Android Engineering http://free-electrons.com