From: Dan Carpenter <dan.carpenter@oracle.com>
To: Balaji T K <balajitk@ti.com>
Cc: Chris Ball <cjb@laptop.org>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <rob.herring@calxeda.com>,
linux-mmc@vger.kernel.org, linux-omap@vger.kernel.org,
devicetree@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] mmc: omap_hsmmc: precedence bug in omap_hsmmc_context_restore()
Date: Thu, 30 Jan 2014 15:15:26 +0300 [thread overview]
Message-ID: <20140130121526.GO4815@mwanda> (raw)
In-Reply-To: <52162444.1050908@ti.com>
On Thu, Aug 22, 2013 at 08:16:28PM +0530, Balaji T K wrote:
> On Thursday 22 August 2013 06:26 PM, Dan Carpenter wrote:
> >'!' has higher precedence than '&' so this doesn't work as intended
> >although since RESETDONE is 1 it would work if none of the other bits
> >are set.
> >
> Hi Dan,
>
> Thanks for the patch, Indeed other bits are reserved.
> however ...
>
> >Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >---
> >Untested.
> >
> >diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> >index 1865321..7346b15 100644
> >--- a/drivers/mmc/host/omap_hsmmc.c
> >+++ b/drivers/mmc/host/omap_hsmmc.c
> >@@ -612,7 +612,7 @@ static int omap_hsmmc_context_restore(struct omap_hsmmc_host *host)
> > if (host->context_loss == context_loss)
> > return 1;
> >
> >- if (!OMAP_HSMMC_READ(host->base, SYSSTATUS) & RESETDONE)
> >+ if (!(OMAP_HSMMC_READ(host->base, SYSSTATUS) & RESETDONE))
> > return 1;
>
> This check is unnecessary, will send a patch to remove this.
What happened with this?
regards,
dan carpenter
next prev parent reply other threads:[~2014-01-30 12:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-22 12:56 [patch] mmc: omap_hsmmc: precedence bug in omap_hsmmc_context_restore() Dan Carpenter
2013-08-22 14:46 ` Balaji T K
2014-01-30 12:15 ` Dan Carpenter [this message]
2014-01-30 13:04 ` Balaji T K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140130121526.GO4815@mwanda \
--to=dan.carpenter@oracle.com \
--cc=balajitk@ti.com \
--cc=cjb@laptop.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).