From: David Miller <davem@davemloft.net>
To: srinivas.kandagatla@st.com
Cc: netdev@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, rob@landley.net, linux@arm.linux.org.uk,
stuart.menefy@st.com, peppe.cavallaro@st.com,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kernel@stlinux.com
Subject: Re: [PATCH v1 1/3] net: stmmac:sti: Add STi SOC glue driver.
Date: Thu, 06 Feb 2014 19:53:42 -0800 (PST) [thread overview]
Message-ID: <20140206.195342.1998479313077409827.davem@davemloft.net> (raw)
In-Reply-To: <1391428868-27245-1-git-send-email-srinivas.kandagatla@st.com>
From: <srinivas.kandagatla@st.com>
Date: Mon, 3 Feb 2014 12:01:08 +0000
> + res = platform_get_resource_byname(pdev,
> + IORESOURCE_MEM, "sti-ethconf");
This is not the correct way to format multi-line function calls,
you'll need to fix this up in this entire series.
The arguments on the second and subsequent lines must start at
the first column after the openning parenthesis of the function
call. You must use the appropriate number of both space and
TAB characters necessary to do so.
If you're only using TAB characters to indent, you're doing it
wrong.
Thank you.
next prev parent reply other threads:[~2014-02-07 3:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-03 11:59 [PATCH v1 0/3] net: stmmac: Add STi GMAC ethernet srinivas.kandagatla
2014-02-03 12:01 ` [PATCH v1 1/3] net: stmmac:sti: Add STi SOC glue driver srinivas.kandagatla
2014-02-07 3:53 ` David Miller [this message]
2014-02-07 7:54 ` srinivas kandagatla
2014-02-03 12:01 ` [PATCH v1 2/3] ARM: STi: Add STiH415 ethernet support srinivas.kandagatla
2014-02-03 12:02 ` [PATCH v1 3/3] ARM: STi: Add STiH416 " srinivas.kandagatla
2014-02-07 10:54 ` [PATCH v2 0/3] net: stmmac: Add STi GMAC ethernet srinivas.kandagatla
2014-02-07 10:55 ` [PATCH v2 1/3] net: stmmac:sti: Add STi SOC glue driver srinivas.kandagatla
2014-02-10 22:40 ` David Miller
2014-02-11 9:01 ` srinivas kandagatla
2014-02-07 10:55 ` [PATCH v2 2/3] ARM: STi: Add STiH415 ethernet support srinivas.kandagatla
2014-02-07 10:55 ` [PATCH v2 3/3] ARM: STi: Add STiH416 " srinivas.kandagatla
2014-02-11 9:58 ` [PATCH v3 0/3] net: stmmac: Add STi GMAC ethernet srinivas.kandagatla
2014-02-11 9:59 ` [PATCH v3 1/3] net: stmmac:sti: Add STi SOC glue driver srinivas.kandagatla
2014-02-11 10:00 ` [PATCH v3 2/3] ARM: STi: Add STiH415 ethernet support srinivas.kandagatla
2014-02-11 10:00 ` [PATCH v3 3/3] ARM: STi: Add STiH416 " srinivas.kandagatla
2014-02-13 21:25 ` [PATCH v3 0/3] net: stmmac: Add STi GMAC ethernet David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140206.195342.1998479313077409827.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@stlinux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=peppe.cavallaro@st.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@st.com \
--cc=stuart.menefy@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).