From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
To: Ian Campbell <ijc-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>
Cc: Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
linux ARM
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
Ben Peddell <klightspeed-aslSrjg9ejhWX4hkXwHRhw@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Herring <robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Subject: Re: [PATCH 4/4] ARM: Kirkwood: Add support for many Synology NAS devices
Date: Thu, 6 Feb 2014 17:50:03 +0100 [thread overview]
Message-ID: <20140206165003.GJ29860@lunn.ch> (raw)
In-Reply-To: <1391704765.2162.7.camel-ommiHX4a84BXesXXhkcM7miJhflN2719@public.gmane.org>
On Thu, Feb 06, 2014 at 04:39:25PM +0000, Ian Campbell wrote:
> On Thu, 2014-02-06 at 10:39 -0500, Jason Cooper wrote:
> >
> > > + pmx_fan_33: pmx-fan-33 {
> > > + marvell,pins = "mpp33";
> > > + marvell,function = "gpo";
> > > + };
>
> Typo I think.
Hi Ian
drivers/pinctrl/mvebu/pinctrl-kirkwood.c:
MPP_MODE(33,
MPP_VAR_FUNCTION(0x0, "gpo", NULL, V(0, 1, 1, 1, 1, 0)),
MPP_VAR_FUNCTION(0x2, "tdm", "dtx", V(0, 0, 1, 1, 1, 0)),
MPP_VAR_FUNCTION(0x3, "ge1", "txctl", V(0, 1, 1, 1, 1, 0)),
MPP_VAR_FUNCTION(0xb, "lcd", "d13", V(0, 0, 0, 0, 1, 0))),
MPP_MODE(34,
It is output only.
I actually had the opposite bug in v1, setup two gpo's as gpio's.
Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-02-06 16:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1391634309-3123-1-git-send-email-andrew@lunn.ch>
[not found] ` <1391634309-3123-3-git-send-email-andrew@lunn.ch>
[not found] ` <1391634309-3123-3-git-send-email-andrew-g2DYL2Zd6BY@public.gmane.org>
2014-02-06 15:19 ` [PATCH 2/4] DT: Vendor prefixes: Add ricoh, ssi and synology Jason Cooper
[not found] ` <1391634309-3123-4-git-send-email-andrew@lunn.ch>
[not found] ` <1391634309-3123-4-git-send-email-andrew-g2DYL2Zd6BY@public.gmane.org>
2014-02-06 15:21 ` [PATCH 3/4] DT: i2c: Trivial: Add sii,s35390a Jason Cooper
[not found] ` <1391634309-3123-5-git-send-email-andrew@lunn.ch>
2014-02-06 15:39 ` [PATCH 4/4] ARM: Kirkwood: Add support for many Synology NAS devices Jason Cooper
2014-02-06 16:01 ` Andrew Lunn
2014-02-06 16:38 ` Arnd Bergmann
2014-02-06 17:03 ` Andrew Lunn
[not found] ` <20140206170333.GK29860-g2DYL2Zd6BY@public.gmane.org>
2014-02-06 17:26 ` Jason Cooper
[not found] ` <20140206160126.GH29860-g2DYL2Zd6BY@public.gmane.org>
2014-02-07 7:44 ` Ben Peddell
2014-02-10 11:41 ` Ian Campbell
2014-02-06 16:39 ` Ian Campbell
[not found] ` <1391704765.2162.7.camel-ommiHX4a84BXesXXhkcM7miJhflN2719@public.gmane.org>
2014-02-06 16:50 ` Andrew Lunn [this message]
2014-02-06 16:52 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140206165003.GJ29860@lunn.ch \
--to=andrew-g2dyl2zd6by@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=ijc-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org \
--cc=klightspeed-aslSrjg9ejhWX4hkXwHRhw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).