From: David Miller <davem@davemloft.net>
To: dinguyen@altera.com
Cc: netdev@vger.kernel.org, dinh.linux@gmail.com,
devicetree@vger.kernel.org, peppe.cavallaro@st.com,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
vbridgers2013@gmail.com
Subject: Re: [PATCHv2 1/2] net: stmmac: Add SOCFPGA glue driver
Date: Sun, 09 Feb 2014 18:06:42 -0800 (PST) [thread overview]
Message-ID: <20140209.180642.1194468196963903290.davem@davemloft.net> (raw)
In-Reply-To: <1391728795-30435-1-git-send-email-dinguyen@altera.com>
From: <dinguyen@altera.com>
Date: Thu, 6 Feb 2014 17:19:54 -0600
> +MODULE_ALIAS("platform:socfpga-dwmac");
> +MODULE_AUTHOR("Dinh Nguyen <dinguyen@altera.com>");
> +MODULE_LICENSE("GPL v2");
> +MODULE_DESCRIPTION("Altera SOCFPGA DWMAC Glue Layer");
> +
Do not add stray empty lines at the end of files. Your second patch
has this problem is a few places too.
next prev parent reply other threads:[~2014-02-10 2:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-06 23:19 [PATCHv2 1/2] net: stmmac: Add SOCFPGA glue driver dinguyen-EIB2kfCEclfQT0dZR+AlfA
2014-02-06 23:19 ` [PATCHv2 2/2] dts: socfpga: Add DTS entry for adding the stmmac glue layer for stmmac dinguyen
2014-02-10 2:06 ` David Miller [this message]
[not found] ` <20140209.180642.1194468196963903290.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2014-02-10 15:52 ` [PATCHv2 1/2] net: stmmac: Add SOCFPGA glue driver Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140209.180642.1194468196963903290.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@altera.com \
--cc=dinh.linux@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
--cc=vbridgers2013@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).