From: David Miller <davem@davemloft.net>
To: srinivas.kandagatla@st.com
Cc: netdev@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, rob@landley.net, linux@arm.linux.org.uk,
stuart.menefy@st.com, peppe.cavallaro@st.com,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kernel@stlinux.com
Subject: Re: [PATCH v2 1/3] net: stmmac:sti: Add STi SOC glue driver.
Date: Mon, 10 Feb 2014 14:40:54 -0800 (PST) [thread overview]
Message-ID: <20140210.144054.2066120014050984537.davem@davemloft.net> (raw)
In-Reply-To: <1391770525-24349-1-git-send-email-srinivas.kandagatla@st.com>
From: <srinivas.kandagatla@st.com>
Date: Fri, 7 Feb 2014 10:55:25 +0000
> + if (dwmac->interface == PHY_INTERFACE_MODE_MII ||
> + dwmac->interface == PHY_INTERFACE_MODE_GMII) {
This is not indented correctly, the first character on the second line should
line up exactly at the column after the openning parenthesis on the first
line.
The objective is not to indent using only TAB characters, which you
are doing here.
Rather, the objective is to use the appropriate number of TAB _and_
space characters necessary to reach the proper column.
> + const char *rs;
> + err = of_property_read_string(np, "st,tx-retime-src", &rs);
Please add an empty line after the local variable declaration.
> + if (!strcasecmp(rs, "clk_125"))
> + dwmac->is_tx_retime_src_clk_125 = true;
> +
> + }
That empty line is superfluous, please delete it.
next prev parent reply other threads:[~2014-02-10 22:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-03 11:59 [PATCH v1 0/3] net: stmmac: Add STi GMAC ethernet srinivas.kandagatla
2014-02-03 12:01 ` [PATCH v1 1/3] net: stmmac:sti: Add STi SOC glue driver srinivas.kandagatla
2014-02-07 3:53 ` David Miller
2014-02-07 7:54 ` srinivas kandagatla
2014-02-03 12:01 ` [PATCH v1 2/3] ARM: STi: Add STiH415 ethernet support srinivas.kandagatla
2014-02-03 12:02 ` [PATCH v1 3/3] ARM: STi: Add STiH416 " srinivas.kandagatla
2014-02-07 10:54 ` [PATCH v2 0/3] net: stmmac: Add STi GMAC ethernet srinivas.kandagatla
2014-02-07 10:55 ` [PATCH v2 1/3] net: stmmac:sti: Add STi SOC glue driver srinivas.kandagatla
2014-02-10 22:40 ` David Miller [this message]
2014-02-11 9:01 ` srinivas kandagatla
2014-02-07 10:55 ` [PATCH v2 2/3] ARM: STi: Add STiH415 ethernet support srinivas.kandagatla
2014-02-07 10:55 ` [PATCH v2 3/3] ARM: STi: Add STiH416 " srinivas.kandagatla
2014-02-11 9:58 ` [PATCH v3 0/3] net: stmmac: Add STi GMAC ethernet srinivas.kandagatla
2014-02-11 9:59 ` [PATCH v3 1/3] net: stmmac:sti: Add STi SOC glue driver srinivas.kandagatla
2014-02-11 10:00 ` [PATCH v3 2/3] ARM: STi: Add STiH415 ethernet support srinivas.kandagatla
2014-02-11 10:00 ` [PATCH v3 3/3] ARM: STi: Add STiH416 " srinivas.kandagatla
2014-02-13 21:25 ` [PATCH v3 0/3] net: stmmac: Add STi GMAC ethernet David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140210.144054.2066120014050984537.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@stlinux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=pawel.moll@arm.com \
--cc=peppe.cavallaro@st.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@st.com \
--cc=stuart.menefy@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).