From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH v2 07/11] watchdog: xilinx: Use of_property_read_u32 Date: Tue, 11 Feb 2014 12:20:38 -0800 Message-ID: <20140211202038.GC11798@roeck-us.net> References: <7aa6e41032ebad0ffb2e1df20beb4f00e38d29e2.1392101734.git.michal.simek@xilinx.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <7aa6e41032ebad0ffb2e1df20beb4f00e38d29e2.1392101734.git.michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Michal Simek Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, monstr-pSz03upnqPeHXe+LvDLADg@public.gmane.org, Wim Van Sebroeck , Grant Likely , Rob Herring , linux-watchdog-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Tue, Feb 11, 2014 at 07:55:50AM +0100, Michal Simek wrote: > Use of_property_read_u32 functions to clean probe function. > > Signed-off-by: Michal Simek > --- > [ ... ] > + > + if (enable_once) > watchdog_set_nowayout(xilinx_wdt_wdd, true); > - } watchdog_set_nowayout(xilinx_wdt_wdd, enable_once); would probably do as well (the function checks the flag as well). Nitpick, so Reviewed-by: Guenter Roeck -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html