From: Mark Rutland <mark.rutland@arm.com>
To: "Heiko Stübner" <heiko@sntech.de>
Cc: "grant.likely@linaro.org" <grant.likely@linaro.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH 0/3] of: functions to count number of elements and convert regulators
Date: Wed, 12 Feb 2014 09:25:29 +0000 [thread overview]
Message-ID: <20140212092528.GA21992@e106331-lin.cambridge.arm.com> (raw)
In-Reply-To: <2573561.oCYNnnL0gm@phil>
Hi Heiko,
On Tue, Feb 11, 2014 at 11:59:25PM +0000, Heiko Stübner wrote:
> In a different thread [0] Mark Rutland suggested that drivers should not
> repeatedly open-code the counting of array elements in a property as well
> as handling the format and endianes of the DTB, as these should be limited
> to the of_ helper functions.
>
> Therefore the first patch introduces a set of helper functions for counting
> the number of u8,...,u64 elements in a property.
>
> The second and third patch convert the two regulator drivers that use this
> pattern to instead use both of_property_count_u32_elemens as well as
> of_property_read_u32_index.
>
> gpio-regulator change tested on a s3c2416-based device, ti-abb-regulator
> compile-tested only.
Cheers for this. All the patches look fine to me, so for the series:
Acked-by: Mark Rutland <mark.rutland@arm.com>
Thanks,
Mark.
prev parent reply other threads:[~2014-02-12 9:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-11 23:59 [PATCH 0/3] of: functions to count number of elements and convert regulators Heiko Stübner
2014-02-12 0:00 ` [PATCH 1/3] of: add functions to count number of elements in a property Heiko Stübner
2014-02-12 15:48 ` Mark Brown
2014-02-12 0:01 ` [PATCH 2/3] regulator: gpio-regulator: do not open-code counting and access of dt array elements Heiko Stübner
2014-02-12 15:51 ` Mark Brown
2014-02-12 0:01 ` [PATCH 3/3] regulator: ti-abb-regulator: " Heiko Stübner
2014-02-12 15:50 ` Mark Brown
2014-02-12 9:25 ` Mark Rutland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140212092528.GA21992@e106331-lin.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=heiko@sntech.de \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).