Re: [PATCH] ARM: mm: cache-l2x0: Check for status property of DT node

Re: [PATCH] ARM: mm: cache-l2x0: Check for status property of DT node

[Tomasz Figa]

[making Cc list a bit more comprehensive]

On 12.02.2014 13:01, Tushar Behera wrote:
> Currently only the DT node is checked during l2x0 cache initialization,
> but it doesn't check the status of the DT node. Thus it gets called
> even if the status of DT node for L2 controller is disabled.
>
> Add explicit check to ensure that L2 cache is initialized only for
> desired boards.
>
> Reported-by: Tomasz Figa <t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> Signed-off-by: Tushar Behera <tushar.behera-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> ---
>   arch/arm/mm/cache-l2x0.c |    3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm/mm/cache-l2x0.c b/arch/arm/mm/cache-l2x0.c
> index 7abde2c..f075cb1 100644
> --- a/arch/arm/mm/cache-l2x0.c
> +++ b/arch/arm/mm/cache-l2x0.c
> @@ -978,6 +978,9 @@ int __init l2x0_of_init(u32 aux_val, u32 aux_mask)
>   	if (!np)
>   		return -ENODEV;
>
> +	if (!of_device_is_available(np))
> +		return -ENODEV;
> +
>   	if (of_address_to_resource(np, 0, &res))
>   		return -ENODEV;
>
>

Reviewed-by: Tomasz Figa <t.figa-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>

Best regards,
Tomasz
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ARM: mm: cache-l2x0: Check for status property of DT node

[Mark Rutland]

On Wed, Feb 12, 2014 at 12:42:49PM +0000, Tomasz Figa wrote:
> [making Cc list a bit more comprehensive]
> 
> On 12.02.2014 13:01, Tushar Behera wrote:
> > Currently only the DT node is checked during l2x0 cache initialization,
> > but it doesn't check the status of the DT node. Thus it gets called
> > even if the status of DT node for L2 controller is disabled.
> >
> > Add explicit check to ensure that L2 cache is initialized only for
> > desired boards.
> >
> > Reported-by: Tomasz Figa <t.figa@samsung.com>
> > Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
> > ---
> >   arch/arm/mm/cache-l2x0.c |    3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/arch/arm/mm/cache-l2x0.c b/arch/arm/mm/cache-l2x0.c
> > index 7abde2c..f075cb1 100644
> > --- a/arch/arm/mm/cache-l2x0.c
> > +++ b/arch/arm/mm/cache-l2x0.c
> > @@ -978,6 +978,9 @@ int __init l2x0_of_init(u32 aux_val, u32 aux_mask)
> >   	if (!np)
> >   		return -ENODEV;
> >
> > +	if (!of_device_is_available(np))
> > +		return -ENODEV;
> > +
> >   	if (of_address_to_resource(np, 0, &res))
> >   		return -ENODEV;
> >
> >
> 
> Reviewed-by: Tomasz Figa <t.figa@samsung.com>

Looks sensible to me.

Acked-by: Mark Rutland <mark.rutland@arm.com>

Thanks,
Mark.