From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anatolij Gustschin Subject: Re: [PATCH] gpu:drm:tilcdc: backlight node never found Date: Fri, 14 Feb 2014 00:37:20 +0100 Message-ID: <20140214003720.168c2d10@crub> References: <1392299258-16968-1-git-send-email-hs@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1392299258-16968-1-git-send-email-hs-ynQEQJNshbs@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Heiko Schocher Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Benoit Parrot , Rob Clark , David Airlie , Grant Likely , Rob Herring , Tomi Valkeinen , Sachin Kamat , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Thu, 13 Feb 2014 14:47:38 +0100 Heiko Schocher wrote: > In panel_probe() the backlight node is never found, correct this. > > Signed-off-by: Heiko Schocher Acked-by: Anatolij Gustschin > Cc: Anatolij Gustschin > Cc: Benoit Parrot > Cc: Rob Clark > Cc: David Airlie > Cc: Grant Likely > Cc: Rob Herring > Cc: Tomi Valkeinen > Cc: Sachin Kamat > Cc: dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org > Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > --- > drivers/gpu/drm/tilcdc/tilcdc_panel.c | 13 ++++++++++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c > index 86c6732..0b97cf4 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c > @@ -356,6 +356,7 @@ static struct of_device_id panel_of_match[]; > static int panel_probe(struct platform_device *pdev) > { > struct device_node *node = pdev->dev.of_node; > + struct device_node *backlight_node; > struct panel_module *panel_mod; > struct tilcdc_module *mod; > struct pinctrl *pinctrl; > @@ -395,9 +396,15 @@ static int panel_probe(struct platform_device *pdev) > > mod->preferred_bpp = panel_mod->info->bpp; > > - panel_mod->backlight = of_find_backlight_by_node(node); > - if (panel_mod->backlight) > - dev_info(&pdev->dev, "found backlight\n"); > + backlight_node = of_parse_phandle(pdev->dev.of_node, "backlight", 0); > + if (backlight_node) { > + panel_mod->backlight = > + of_find_backlight_by_node(backlight_node); > + if (panel_mod->backlight) > + dev_info(&pdev->dev, "found backlight\n"); > + } else { > + dev_warn(&pdev->dev, "backlight node missing...\n"); > + } > > return 0; > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html