From: Lee Jones <lee.jones@linaro.org>
To: Roger Quadros <rogerq@ti.com>
Cc: tony@atomide.com, bcousson@baylibre.com, balbi@ti.com, nm@ti.com,
khilman@linaro.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-usb@vger.kernel.org, Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH v7 03/12] mfd: omap-usb-host: Use clock names as per function for reference clocks
Date: Fri, 14 Feb 2014 13:33:30 +0000 [thread overview]
Message-ID: <20140214133330.GC13293@lee--X1> (raw)
In-Reply-To: <52FE164F.80503@ti.com>
> >> Use a meaningful name for the reference clocks so that it indicates the function.
> >>
> >> CC: Lee Jones <lee.jones@linaro.org>
> >> CC: Samuel Ortiz <sameo@linux.intel.com>
> >> Signed-off-by: Roger Quadros <rogerq@ti.com>
> >> ---
> >> drivers/mfd/omap-usb-host.c | 6 +++---
> >> 1 file changed, 3 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
> >> index 60a3bed..ce620a8 100644
> >> --- a/drivers/mfd/omap-usb-host.c
> >> +++ b/drivers/mfd/omap-usb-host.c
> >> @@ -714,21 +714,21 @@ static int usbhs_omap_probe(struct platform_device *pdev)
> >> goto err_mem;
> >> }
> >>
> >> - omap->xclk60mhsp1_ck = devm_clk_get(dev, "xclk60mhsp1_ck");
> >> + omap->xclk60mhsp1_ck = devm_clk_get(dev, "refclk_60m_ext_p1");
> >
> > You can't do that. These changes will have to be in the same patch as
> > the core change i.e. where they are initialised.
>
> I'm not touching them anywhere in this series. When core changes are you
> referring to?
The ones in:
arch/arm/mach-omap2/cclock3xxx_data.c
> >> if (IS_ERR(omap->xclk60mhsp1_ck)) {
> >> ret = PTR_ERR(omap->xclk60mhsp1_ck);
> >> dev_err(dev, "xclk60mhsp1_ck failed error:%d\n", ret);
> >> goto err_mem;
> >> }
> >>
> >> - omap->xclk60mhsp2_ck = devm_clk_get(dev, "xclk60mhsp2_ck");
> >> + omap->xclk60mhsp2_ck = devm_clk_get(dev, "refclk_60m_ext_p2");
> >> if (IS_ERR(omap->xclk60mhsp2_ck)) {
> >> ret = PTR_ERR(omap->xclk60mhsp2_ck);
> >> dev_err(dev, "xclk60mhsp2_ck failed error:%d\n", ret);
> >> goto err_mem;
> >> }
> >>
> >> - omap->init_60m_fclk = devm_clk_get(dev, "init_60m_fclk");
> >> + omap->init_60m_fclk = devm_clk_get(dev, "refclk_60m_int");
> >> if (IS_ERR(omap->init_60m_fclk)) {
> >> ret = PTR_ERR(omap->init_60m_fclk);
> >> dev_err(dev, "init_60m_fclk failed error:%d\n", ret);
> >
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-02-14 13:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-12 10:18 [PATCH v7 00/12] USB Host support for OMAP5 uEVM Roger Quadros
2014-02-12 10:18 ` [PATCH v7 01/12] mfd: omap-usb-host: Use resource managed clk_get() Roger Quadros
[not found] ` <1392200333-28397-2-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2014-02-14 9:57 ` Lee Jones
2014-02-12 10:18 ` [PATCH v7 02/12] mfd: omap-usb-host: Get clocks based on hardware revision Roger Quadros
2014-02-14 10:07 ` Lee Jones
2014-02-14 11:12 ` Roger Quadros
2014-02-12 10:18 ` [PATCH v7 03/12] mfd: omap-usb-host: Use clock names as per function for reference clocks Roger Quadros
[not found] ` <1392200333-28397-4-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2014-02-14 10:09 ` Lee Jones
2014-02-14 13:12 ` Roger Quadros
2014-02-14 13:33 ` Lee Jones [this message]
2014-02-18 15:28 ` Roger Quadros
2014-02-18 16:07 ` Lee Jones
2014-02-12 10:18 ` [PATCH v7 04/12] mfd: omap-usb-host: Update DT clock binding information Roger Quadros
2014-02-12 10:18 ` [PATCH v7 05/12] mfd: omap-usb-tll: " Roger Quadros
2014-02-12 10:18 ` [PATCH v7 06/12] ARM: dts: omap4: Update omap-usb-host node Roger Quadros
2014-02-12 10:18 ` [PATCH v7 07/12] ARM: dts: omap5: " Roger Quadros
2014-02-12 10:18 ` [PATCH v7 08/12] ARM: dts: omap4-panda: Provide USB PHY clock Roger Quadros
[not found] ` <1392200333-28397-1-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2014-02-12 10:18 ` [PATCH v7 09/12] ARM: dts: omap5-uevm: " Roger Quadros
2014-02-12 10:18 ` [PATCH v7 10/12] ARM: OMAP2+: Remove legacy_init_ehci_clk() Roger Quadros
2014-02-12 10:18 ` [PATCH v7 11/12] ARM: dts: OMAP2+: Get rid of incompatible ids for USB host nodes Roger Quadros
2014-02-12 10:18 ` [PATCH v7 12/12] usb: omap: dts: Update DT binding example usage Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140214133330.GC13293@lee--X1 \
--to=lee.jones@linaro.org \
--cc=balbi@ti.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nm@ti.com \
--cc=rogerq@ti.com \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).