From: Felipe Balbi <balbi@ti.com>
To: Josh Cartwright <joshc@codeaurora.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org,
Sagar Dharia <sdharia@codeaurora.org>,
Gilad Avidov <gavidov@codeaurora.org>,
Michael Bohan <mbohan@codeaurora.org>,
Kenneth Heitke <kheitke@codeaurora.org>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v5 1/6] spmi: Linux driver framework for SPMI
Date: Sat, 15 Feb 2014 17:47:48 -0600 [thread overview]
Message-ID: <20140215234748.GA26494@saruman.home> (raw)
In-Reply-To: <1391468739-20987-2-git-send-email-joshc@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 535 bytes --]
Hi,
On Mon, Feb 03, 2014 at 05:05:33PM -0600, Josh Cartwright wrote:
[ snip ]
> +#ifdef CONFIG_PM_RUNTIME
> +static int spmi_runtime_suspend(struct device *dev)
> +{
> + struct spmi_device *sdev = to_spmi_device(dev);
> + int err;
> +
> + err = pm_generic_runtime_suspend(dev);
> + if (err)
> + return err;
> +
> + return spmi_command_sleep(sdev);
shouldn't this too calls be swapped ? I mean, some pm_runtime
implementations could be gating clocks at the driver's
->runtime_suspend() callback.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-02-15 23:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1391468739-20987-1-git-send-email-joshc@codeaurora.org>
2014-02-03 23:05 ` [PATCH v5 1/6] spmi: Linux driver framework for SPMI Josh Cartwright
2014-02-15 19:23 ` Greg Kroah-Hartman
2014-02-15 23:47 ` Felipe Balbi [this message]
2014-02-18 18:56 ` Josh Cartwright
2014-02-03 23:05 ` [PATCH v5 2/6] spmi: add generic SPMI controller binding documentation Josh Cartwright
2014-02-03 23:05 ` [PATCH v5 3/6] spmi: Add MSM PMIC Arbiter SPMI controller Josh Cartwright
2014-02-03 23:05 ` [PATCH v5 5/6] spmi: document the PMIC arbiter SPMI bindings Josh Cartwright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140215234748.GA26494@saruman.home \
--to=balbi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gavidov@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=joshc@codeaurora.org \
--cc=kheitke@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mbohan@codeaurora.org \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sdharia@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).