From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [PATCH] net: add init-regs for of_phy support Date: Mon, 17 Feb 2014 14:12:22 +0000 Message-ID: <20140217141222.GB19308@e106331-lin.cambridge.arm.com> References: <1392642484-19938-1-git-send-email-ben.dooks@codethink.co.uk> <1392642484-19938-2-git-send-email-ben.dooks@codethink.co.uk> <20140217134448.GA19308@e106331-lin.cambridge.arm.com> <530213A4.4030400@codethink.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <530213A4.4030400@codethink.co.uk> Sender: linux-sh-owner@vger.kernel.org To: Ben Dooks Cc: "netdev@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-sh@vger.kernel.org" List-Id: devicetree@vger.kernel.org On Mon, Feb 17, 2014 at 01:50:28PM +0000, Ben Dooks wrote: > On 17/02/14 13:44, Mark Rutland wrote: > > On Mon, Feb 17, 2014 at 01:08:04PM +0000, Ben Dooks wrote: > >> Add new init-regs field for of_phy nodes and make sure these > >> get applied when the phy is configured. > >> > >> This allows any phy node in an fdt to initialise registers > >> that may not be set as standard by the driver at initialisation > >> time, such as LED controls. > > > > Why not have a driver for the particular PHY? If it's not standard we > > don't need to pretend it is. If it has some extensions then the standard > > compatible string can be a fallback entry in the compatible list. > > I was trying to provide some useful and reasonably generic code > to setup PHYs without having to add specific arguments to each of > them. > > I could have added something like ksz8041,led-mode1 = <1> and > updated the micrel driver. Perhaps. It depends on precisely what the property is describing. I think describing the hardware and letting Linux figure out what to do is better than giving it a set of opaque instructions for it to blindly follow. Thanks, Mark.