From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 1/2] mfd: palmas: support IRQ inversion at the board level Date: Tue, 18 Feb 2014 18:01:52 +0000 Message-ID: <20140218180152.GB31706@lee--X1> References: <1392415108-4365-1-git-send-email-swarren@wwwdotorg.org> <20140217092658.GC17875@lee--X1> <53039B6D.8080004@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <53039B6D.8080004-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Stephen Warren Cc: Samuel Ortiz , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, J Keerthy , Ian Lartey , Stefan Agner , josephl-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org, Stephen Warren List-Id: devicetree@vger.kernel.org > >> From: Stephen Warren > >> > >> Some boards or SoCs have an inverter between the PMIC IRQ output p= in and > >> the IRQ controller input signal. > >> > >> The IRQ specifier in DT is meant to represent the IRQ flags at the= input > >> to the IRQ controller. > >> > >> The Palmas HW's IRQ output has configurable polarity. The driver > >> currently selects the output polarity by querying the input polari= ty at > >> the IRQ controller. This works fine if the IRQ signal is routed di= rectly > >> from the PMIC to the IRQ controller with no intervening logic. How= ever, > >> if the signal is inverted between the two, this automatic polarity > >> selection gets the wrong answer. > >> > >> Add an additional optional DT and platform data parameter which in= dicates > >> that such an inversion occurs. If this option is enabled, the Palm= as > >> driver will configure its IRQ output to the opposite polarity of t= he IRQ > >> controller's input. > >> > >> An alternative would have been to add a new non-optional DT parame= ter to > >> indicate the exact desired output polarity. However, this would ha= ve been > >> an incompatible change to the DT binding. > >> > >> Signed-off-by: Stephen Warren > >> --- > >> If this patch could be applied to its own branch (w/ signed tag) i= n the > >> MFD tree, that would great; then I can pull patch 1/2 into the Teg= ra tree > >> so that I can apply patch 2/2 to the Tegra tree. Thanks. > >> --- > >> Documentation/devicetree/bindings/mfd/palmas.txt | 6 ++++++ > >> drivers/mfd/palmas.c | 4 ++++ > >> include/linux/mfd/palmas.h | 1 + > >> 3 files changed, 11 insertions(+) > >=20 > > For the core changes: > > Acked-by: Lee Jones >=20 > Thanks. Since you ack'd this and are an MFD maintainer, was that an > indication that I should take this patch through the Tegra tree? No, it was an indication that we still require more Acks. :) --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog