Re: [PATCH v5 1/4] ASoC: tlv320aic32x4: Support for master clock

[Markus Pargmann <mpa@pengutronix.de>]

[-- Attachment #1.1: Type: text/plain, Size: 1582 bytes --]

Hi,

On Tue, Feb 18, 2014 at 10:23:29AM +0900, Mark Brown wrote:
> On Mon, Feb 17, 2014 at 11:04:17AM +0100, Markus Pargmann wrote:
> 
> >  Optional properties:
> >   - reset-gpios: Reset-GPIO phandle with args as described in gpio/gpio.txt
> > + - clocks/clock-names: Clock named 'mclk' for the master clock of the codec.
> > +   See clock/clock-bindings.txt for information about the detailed format.
> 
> Looking at the code the clock isn't physically optional, why not make it
> mandatory?  There's only one mainline user, it looks like it should be
> straightforward to update with a fixed clock.

The masterclock is physically optional. There are several modes to use
this codec without master clock. The PLL can use different clock inputs,
BCLK, MCLK, etc. and even the PLL is not necessary. Instead BCLK and so
on can be used as direct codec clock input. However, most of this is not
supported by the driver yet and I can't test these cases.

> 
> > +	aic32x4->mclk = devm_clk_get(&i2c->dev, "mclk");
> > +	if (IS_ERR(aic32x4->mclk))
> > +		dev_info(&i2c->dev, "No mclk found, continuing without clock\n");
> 
> This is going to break with deferred probe, we need to handle that at
> least.

Yes, I fixed this.

Thanks,

Markus


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]