From: Sebastian Capella <sebastian.capella@linaro.org>
To: devicetree@vger.kernel.org
Cc: Mark Rutland <mark.rutland@arm.com>,
Mike Turquette <mturquette@linaro.org>,
Tomasz Figa <t.figa@samsung.com>,
Mark Hambleton <mark.hambleton@broadcom.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Russell King <linux@arm.linux.org.uk>,
Nicolas Pitre <nico@linaro.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
linux-arm-kernel@lists.infradead.org,
Grant Likely <grant.likely@linaro.org>,
Dave Martin <dave.martin@arm.com>,
Charles Garcia Tobin <Charles.Garcia-Tobin@arm.com>,
Kevin Hilman <khilman@linaro.org>,
linux-pm@vger.kernel.org, Kumar Gala <galak@codeaurora.org>,
Rob Herring <robh+dt@kernel.org>,
Vincent Guittot <vincent.guittot@linaro.org>,
Antti Miettinen <ananaza@iki.fi>,
Peter De Schrijver <pdeschrijver@nvidia.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Amit Kucheria <amit.kucheria@linaro.org>,
Mark Brown <broonie@kernel.org>, Santosh Shilimkar <santosh.sh>
Subject: Re: [PATCH RFC v4 3/3] Documentation: arm: define DT idle states bindings
Date: Wed, 19 Feb 2014 08:04:49 -0800 [thread overview]
Message-ID: <20140219160449.11460.93660@capellas-linux> (raw)
In-Reply-To: <1392724051-11950-4-git-send-email-lorenzo.pieralisi@arm.com>
Quoting Lorenzo Pieralisi (2014-02-18 03:47:31)
> + - index
> + Usage: Required
> + Value type: <u32>
> + Definition: It represents the idle state index.
> + An increasing index value implies less power
> + consumption. Index must be given a sequential
> + value = {0, 1, ....}, starting from 0.
One minor comment. In the example, it can be tricky to see how this is sequential
since the states interleave. Not sure if it merits rewording here?
These look good to me!
Thanks!
Sebastian
next prev parent reply other threads:[~2014-02-19 16:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-18 11:47 [PATCH RFC v4 0/3] ARM: defining idle states DT bindings Lorenzo Pieralisi
2014-02-18 11:47 ` [PATCH RFC v4 1/3] Documentation: devicetree: psci: define CPU suspend parameter Lorenzo Pieralisi
2014-02-18 11:47 ` [PATCH RFC v4 2/3] Documentation: arm: add cache DT bindings Lorenzo Pieralisi
2014-02-18 11:47 ` [PATCH RFC v4 3/3] Documentation: arm: define DT idle states bindings Lorenzo Pieralisi
2014-02-19 16:04 ` Sebastian Capella [this message]
2014-03-10 18:01 ` Lorenzo Pieralisi
2014-03-10 18:11 ` Sebastian Capella
2014-03-10 18:22 ` Sebastian Capella
2014-03-10 19:13 ` Rob Herring
2014-03-11 12:51 ` Lorenzo Pieralisi
2014-03-17 11:15 ` Antti P Miettinen
2014-03-17 11:53 ` Lorenzo Pieralisi
2014-03-17 13:49 ` Antti P Miettinen
2014-03-17 14:45 ` Lorenzo Pieralisi
2014-03-17 18:26 ` Antti P Miettinen
2014-03-17 19:24 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140219160449.11460.93660@capellas-linux \
--to=sebastian.capella@linaro.org \
--cc=Charles.Garcia-Tobin@arm.com \
--cc=amit.kucheria@linaro.org \
--cc=ananaza@iki.fi \
--cc=broonie@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=dave.martin@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lorenzo.pieralisi@arm.com \
--cc=mark.hambleton@broadcom.com \
--cc=mark.rutland@arm.com \
--cc=mturquette@linaro.org \
--cc=nico@linaro.org \
--cc=pdeschrijver@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=t.figa@samsung.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).