From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Rutland Subject: Re: [PATCH tty-next v2 4/4] Documentation: devicetree: add bindings documentation for bcm63xx-uart Date: Fri, 21 Feb 2014 12:08:54 +0000 Message-ID: <20140221120854.GE8783@e106331-lin.cambridge.arm.com> References: <1392920154-3642-1-git-send-email-f.fainelli@gmail.com> <1392920154-3642-5-git-send-email-f.fainelli@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1392920154-3642-5-git-send-email-f.fainelli@gmail.com> Content-Language: en-US Sender: linux-serial-owner@vger.kernel.org To: Florian Fainelli Cc: "linux-serial@vger.kernel.org" , "devicetree@vger.kernel.org" , "mbizon@freebox.fr" , "jogo@openwrt.org" , "gregkh@linuxfoundation.org" , "gregory.0xf0@gmail.com" List-Id: devicetree@vger.kernel.org On Thu, Feb 20, 2014 at 06:15:54PM +0000, Florian Fainelli wrote: > Add the Device Tree binding documentation for the non-standard BCM63xx > UART hardware block found in the BCM63xx DSL SoCs. > > Signed-off-by: Florian Fainelli This looks fine to me. Acked-by: Mark Rutland > --- > Changes in v2: > - update the compatible property to be "brcm,bcm6345-uart" as suggested > - reword the clocks and clock-names properties based on feedback from Mark > > .../devicetree/bindings/serial/bcm63xx-uart.txt | 27 ++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > create mode 100644 Documentation/devicetree/bindings/serial/bcm63xx-uart.txt > > diff --git a/Documentation/devicetree/bindings/serial/bcm63xx-uart.txt b/Documentation/devicetree/bindings/serial/bcm63xx-uart.txt > new file mode 100644 > index 0000000..f288232 > --- /dev/null > +++ b/Documentation/devicetree/bindings/serial/bcm63xx-uart.txt > @@ -0,0 +1,27 @@ > +Broadcom BCM63xx UART: Non standard UART used in the Broadcom BCM63xx DSL SoCs > + > +Required properties: > +- compatible: must be "brcm,bcm6345-uart" > +- reg: offset and length of the register set for the device > +- interrupts: device interrupt > +- clocks: a list of phandles and clock-specifiers, one for each entry > + in clock-names > +- clock-names: should contain "periph" for the functional clock > + > +Example: > + > +serial0: uart@600 { > + compatible = "brcm,bcm6345-uart"; > + reg = <0x600 0x1b>; > + interrupts = ; > + clocks = <&periph_clk>; > + clock-names = "periph"; > +}; > + > +Note: each UART port must have an alias correctly numbered in the "aliases" > +node, e.g: > + > +aliases { > + uart0 = &serial0; > + uart1 = &serial1; > +}; > -- > 1.8.3.2 > >