From: Mark Rutland <mark.rutland@arm.com>
To: Peter Chen <Peter.Chen@freescale.com>
Cc: "balbi@ti.com" <balbi@ti.com>,
"shawn.guo@linaro.org" <shawn.guo@linaro.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
Pawel Moll <Pawel.Moll@arm.com>,
"alexander.shishkin@linux.intel.com"
<alexander.shishkin@linux.intel.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"festevam@gmail.com" <festevam@gmail.com>,
"marex@denx.de" <marex@denx.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"m.grzeschik@pengutronix.de" <m.grzeschik@pengutronix.de>,
"Frank.Li@freescale.com" <Frank.Li@freescale.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Subject: Re: [PATCH v10 01/15] usb: doc: phy-mxs: Add more compatible strings
Date: Fri, 21 Feb 2014 12:38:31 +0000 [thread overview]
Message-ID: <20140221123831.GG8783@e106331-lin.cambridge.arm.com> (raw)
In-Reply-To: <5e4d795b507a4ea7b9faa69dd05148c4@BL2PR03MB226.namprd03.prod.outlook.com>
On Fri, Feb 21, 2014 at 09:40:29AM +0000, Peter Chen wrote:
>
> > >
> > > Required properties:
> > > -- compatible: Should be "fsl,imx23-usbphy"
> > > +- compatible: "fsl,imx23-usbphy" for imx23 and imx28, "fsl,imx6q-
> > usbphy"
> > > + for imx6dq and imx6dl, "fsl,imx6sl-usbphy" for imx6sl
> >
> > Minor nit, but could we restructure this as something like the following,
> > with each string on a new line:
> >
> > - compatible: should contain:
> > * "fsl,imx23-usbphy" for imx23 and imx28
> > * "fsl,imx6q-usbphy" for imx6dq and imx6dl
> > * "fsl,imx6sl-usbphy" for imx6sl
> >
> > It makes it a bit easier to read.
>
> Thanks, will change like above.
>
> >
> > I see the existing "fsl,imx23-usbphy" is used as a fallback for
> > "fsl,imx28-usbphy", "fsl,imx6q-usbphy", and "fsl,imx6sl-usbphy" in
> > existing DTs.
> >
> > Is this expected going forward? It might be worth mentioning.
> >
>
> These SoCs used the same FSL imx PHY, but different versions.
> imx23/imx28 are the first version, more improvements are at
> later SoCs (like imx6x) version. Keep "fsl,imx23-usbphy" at
> imx6 dts will be user know it is from imx23's. If you think
> it does not need, I can delete "fsl,imx23-usbphy" from imx6 dts.
I'm not arguing to remove it, I'm suggesting it might be worth
mentioning that it's not mutually exclusive, and can be a fallback for
the other strings.
Cheers,
Mark.
next prev parent reply other threads:[~2014-02-21 12:38 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 5:14 [PATCH v10 00/15] Add power management support for mxs phy Peter Chen
2014-02-20 5:14 ` [PATCH v10 01/15] usb: doc: phy-mxs: Add more compatible strings Peter Chen
2014-02-21 9:13 ` Mark Rutland
2014-02-21 9:40 ` Peter Chen
2014-02-21 9:46 ` Marc Kleine-Budde
2014-02-21 9:05 ` Peter Chen
2014-02-21 12:38 ` Mark Rutland [this message]
2014-02-20 5:14 ` [PATCH v10 02/15] usb: phy-mxs: Add platform judgement code Peter Chen
[not found] ` <1392873284-9386-1-git-send-email-peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-02-20 5:14 ` [PATCH v10 03/15] usb: phy-mxs: Add auto clock and power setting Peter Chen
2014-02-20 5:14 ` [PATCH v10 05/15] usb: phy-mxs: Add anatop regmap Peter Chen
2014-02-20 5:14 ` [PATCH v10 10/15] usb: phy-mxs: Add implementation of set_wakeup Peter Chen
2014-02-21 9:21 ` Mark Rutland
[not found] ` <20140221092127.GC7541-NuALmloUBlrZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org>
2014-02-21 9:03 ` Peter Chen
2014-02-20 5:14 ` [PATCH v10 12/15] usb: phy-mxs: Add sync time after controller clear phcd Peter Chen
2014-02-20 5:14 ` [PATCH v10 15/15] ARM: dts: imx6: add mxs phy controller id Peter Chen
2014-02-20 5:14 ` [PATCH v10 04/15] usb: doc: phy-mxs: update binding for adding anatop phandle Peter Chen
[not found] ` <1392873284-9386-5-git-send-email-peter.chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-02-21 9:14 ` Mark Rutland
2014-02-21 8:57 ` Peter Chen
2014-02-20 5:14 ` [PATCH v10 06/15] usb: phy-mxs: change description of usb device speed Peter Chen
2014-02-20 5:14 ` [PATCH v10 07/15] usb: phy-mxs: Enable IC fixes for related SoCs Peter Chen
2014-02-20 5:14 ` [PATCH v10 08/15] usb: phy-mxs: add controller id Peter Chen
2014-02-20 5:14 ` [PATCH v10 09/15] usb: phy: Add set_wakeup API Peter Chen
2014-02-20 5:14 ` [PATCH v10 11/15] usb: phy-mxs: Add system suspend/resume API Peter Chen
2014-02-20 5:14 ` [PATCH v10 13/15] ARM: dts: mxs: add mxs phy controller id Peter Chen
2014-02-20 5:14 ` [PATCH v10 14/15] ARM: dts: imx6: add anatop phandle for usbphy Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140221123831.GG8783@e106331-lin.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=Frank.Li@freescale.com \
--cc=Pawel.Moll@arm.com \
--cc=Peter.Chen@freescale.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=balbi@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=grant.likely@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.grzeschik@pengutronix.de \
--cc=marex@denx.de \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).