Re: [PATCH v12 2/3] ata: Add APM X-Gene SoC AHCI SATA host controller driver

[Tejun Heo <tj@kernel.org>]

Hello, Loc.

On Fri, Feb 21, 2014 at 10:43:52AM -0800, Loc Ho wrote:
> Do you want this for all functions or only one that with comment? Also,
> for both drivers - host and PHY drivres?

Oh, no need to do that for every function.  It's just customary to use
function comment when there's sufficient amount to explain for the
whole function.

> > Can you please go back two reviews and re-read what I requested?
> > Also, if you're unsure, please don't hesitate to ask back.  It's
> > usually a lot easier for both parties than iterating through patchsets
> > without properly understanding each other.
> >
> 
> Before posting this morning, I had gone over all response email from you
> since we first interacted. I am not quite follow what you want here. Are
> you suggesting that I should move this out as an errata patch?

Hmmm... maybe I was too ambiguous.  Because the behavior is quite
unusual and can make the error handling behavior deviate, I think it
deserves to explain 1. why such behavior is necessary and 2. what the
implications are (e.g. in corner cases, how long it could add to reset
timeout) and preferably 3. rationale for choosing this specific
approach given #1 and #2, so that when someone else reads the code
later on [s]he doesn't have to second-guess the original intention of
the workaround.

Thanks.

-- 
tejun