From: Simon Horman <horms@verge.net.au>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: linux-sh@vger.kernel.org, devicetree@vger.kernel.org,
Mike Turquette <mturquette@linaro.org>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH] clk: shmobile: Fix typoe in MSTP clock DT bindings
Date: Mon, 24 Feb 2014 09:35:50 +0900 [thread overview]
Message-ID: <20140224003550.GF3898@verge.net.au> (raw)
In-Reply-To: <1392830004-5706-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
On Wed, Feb 19, 2014 at 06:13:24PM +0100, Laurent Pinchart wrote:
> The DT bindings document a renesas,indices property, while the code, the
> DT example and the DT sources all use renesas,clock-indices. Fix the
> documentation.
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Acked-by: Simon Horman <horms@verge.net.au>
BTW, there is a typo (in the word typo) in the subject :^)
> ---
> Documentation/devicetree/bindings/clock/renesas,cpg-mstp-clocks.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Mike, this is a v3.14 bug fix. You can find all three Renesas clock bugfixes
> for v3.14 in
>
> git://linuxtv.org/pinchartl/fbdev.git clocks/next/drivers
>
> I'll wait a day and send a pull request just to make sure no patch gets
> forgotten.
>
> diff --git a/Documentation/devicetree/bindings/clock/renesas,cpg-mstp-clocks.txt b/Documentation/devicetree/bindings/clock/renesas,cpg-mstp-clocks.txt
> index a6a352c..5992dce 100644
> --- a/Documentation/devicetree/bindings/clock/renesas,cpg-mstp-clocks.txt
> +++ b/Documentation/devicetree/bindings/clock/renesas,cpg-mstp-clocks.txt
> @@ -21,9 +21,9 @@ Required Properties:
> must appear in the same order as the output clocks.
> - #clock-cells: Must be 1
> - clock-output-names: The name of the clocks as free-form strings
> - - renesas,indices: Indices of the gate clocks into the group (0 to 31)
> + - renesas,clock-indices: Indices of the gate clocks into the group (0 to 31)
>
> -The clocks, clock-output-names and renesas,indices properties contain one
> +The clocks, clock-output-names and renesas,clock-indices properties contain one
> entry per gate clock. The MSTP groups are sparsely populated. Unimplemented
> gate clocks must not be declared.
>
> --
> Regards,
>
> Laurent Pinchart
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2014-02-24 0:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 17:13 [PATCH] clk: shmobile: Fix typoe in MSTP clock DT bindings Laurent Pinchart
2014-02-24 0:35 ` Simon Horman [this message]
2014-02-24 0:54 ` Mike Turquette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140224003550.GF3898@verge.net.au \
--to=horms@verge.net.au \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
--cc=mturquette@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).