Re: [PATCH] clk: shmobile: Fix typoe in MSTP clock DT bindings

[Mike Turquette <mturquette@linaro.org>]

Quoting Laurent Pinchart (2014-02-19 09:13:24)
> The DT bindings document a renesas,indices property, while the code, the
> DT example and the DT sources all use renesas,clock-indices. Fix the
> documentation.
> 
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
>  Documentation/devicetree/bindings/clock/renesas,cpg-mstp-clocks.txt | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Mike, this is a v3.14 bug fix. You can find all three Renesas clock bugfixes
> for v3.14 in
> 
>         git://linuxtv.org/pinchartl/fbdev.git clocks/next/drivers
> 
> I'll wait a day and send a pull request just to make sure no patch gets
> forgotten.

Can you provide a description of each regression that gets fixed in the
pull request? This one is obvious: a stable api exposed from the kernel
has a bug and was merged towards 3.14, so a fix in the -rc is
appropriate. It helps to have justifications for fixes when I send my
clk-fixes PR. Also the patch $SUBJECT has a typoe ;-)

Thanks,
Mike

> 
> diff --git a/Documentation/devicetree/bindings/clock/renesas,cpg-mstp-clocks.txt b/Documentation/devicetree/bindings/clock/renesas,cpg-mstp-clocks.txt
> index a6a352c..5992dce 100644
> --- a/Documentation/devicetree/bindings/clock/renesas,cpg-mstp-clocks.txt
> +++ b/Documentation/devicetree/bindings/clock/renesas,cpg-mstp-clocks.txt
> @@ -21,9 +21,9 @@ Required Properties:
>      must appear in the same order as the output clocks.
>    - #clock-cells: Must be 1
>    - clock-output-names: The name of the clocks as free-form strings
> -  - renesas,indices: Indices of the gate clocks into the group (0 to 31)
> +  - renesas,clock-indices: Indices of the gate clocks into the group (0 to 31)
>  
> -The clocks, clock-output-names and renesas,indices properties contain one
> +The clocks, clock-output-names and renesas,clock-indices properties contain one
>  entry per gate clock. The MSTP groups are sparsely populated. Unimplemented
>  gate clocks must not be declared.
>  
> -- 
> Regards,
> 
> Laurent Pinchart
>