From: Nicolin Chen <Guangyu.Chen@freescale.com>
To: "Austin, Brian" <Brian.Austin@cirrus.com>
Cc: Mark Brown <broonie@kernel.org>,
"Handrigan, Paul" <Paul.Handrigan@cirrus.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"pawel.moll@arm.com" <pawel.moll@arm.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"galak@codeaurora.org" <galak@codeaurora.org>,
"rob@landley.net" <rob@landley.net>,
Liam Girdwood <lgirdwood@gmail.com>,
"grant.likely@linaro.org" <grant.likely@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] ASoC: cs42888: Add codec driver support
Date: Mon, 24 Feb 2014 23:47:52 +0800 [thread overview]
Message-ID: <20140224154751.GB6132@MrMyself> (raw)
In-Reply-To: <B745DBDD-8A64-4B98-819B-72F8AFF602DE@cirrus.com>
On Mon, Feb 24, 2014 at 03:52:24PM +0000, Austin, Brian wrote:
>
> >
> >> + /* Disable auto-mute */
> >> + regmap_update_bits(cs42888->regmap, CS42888_TXCTL,
> >> + CS42888_TXCTL_AMUTE | CS42888_TXCTL_DAC_SZC_MASK,
> >> + CS42888_TXCTL_DAC_SZC_SR);
> >
> > Does this interfere with the manual mute controls or is it a separate
> > thing? If it plays nicely with the manual controls it's probably better
> > to leave it enabled since it improves performance in some benchmarks
> > (that's why hardware tends to have the feature).
>
> Auto-Mute should be enabled by default.
>
> >
> >> + if (!IS_ERR(cs42888->clk))
> >> + clk_disable_unprepare(cs42888->clk);
> >
> > Does the device work without MCLK?
> Yes, MCLK is required. If you can’t get the clock you should error out.
>
>
Will refine it as you suggest.
Thank you for the comments.
Nicolin Chen
next prev parent reply other threads:[~2014-02-24 15:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 6:55 [PATCH] ASoC: cs42888: Add codec driver support Nicolin Chen
[not found] ` <1393224929-7555-1-git-send-email-Guangyu.Chen-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2014-02-24 11:30 ` Mark Brown
2014-02-24 15:47 ` Nicolin Chen
2014-02-24 15:52 ` Austin, Brian
2014-02-24 15:47 ` Nicolin Chen [this message]
2014-02-24 16:06 ` Nicolin Chen
2014-02-24 16:32 ` Austin, Brian
2014-02-25 2:32 ` Nicolin Chen
2014-02-25 0:00 ` Mark Brown
2014-02-25 2:38 ` Nicolin Chen
2014-02-25 3:09 ` Mark Brown
2014-02-25 3:13 ` Nicolin Chen
2014-02-25 3:39 ` Mark Brown
2014-02-25 3:46 ` Nicolin Chen
2014-02-25 3:52 ` Mark Brown
2014-02-25 3:54 ` Nicolin Chen
2014-02-25 3:54 ` [alsa-devel] " Fabio Estevam
2014-02-25 3:55 ` Nicolin Chen
2014-02-24 17:54 ` Lars-Peter Clausen
2014-02-25 2:39 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140224154751.GB6132@MrMyself \
--to=guangyu.chen@freescale.com \
--cc=Brian.Austin@cirrus.com \
--cc=Paul.Handrigan@cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).