From: Bjorn Andersson <bjorn.andersson@sonymobile.com>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>, Rob Landley <rob@landley.net>,
Wolfram Sang <wsa@the-dreams.de>,
Grant Likely <grant.likely@linaro.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Stephen Boyd <sboyd@codeaurora.org>,
"Ivan T. Ivanov" <iivanov@mm-sol.com>,
Andy Gross <agross@codeaurora.org>
Subject: Re: [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller
Date: Mon, 24 Feb 2014 10:03:30 -0800 [thread overview]
Message-ID: <20140224180330.GD32621@sonymobile.com> (raw)
In-Reply-To: <20140221081603.GA3931@lukather>
On Fri 21 Feb 00:16 PST 2014, Maxime Ripard wrote:
> Hi Bjorn,
>
> On Thu, Feb 20, 2014 at 04:38:10PM -0800, Bjorn Andersson wrote:
> > +static int qup_i2c_probe(struct platform_device *pdev)
> > +{
>
> [ snip ]
>
> > +
> > + qup_i2c_enable_clocks(qup);
> > +
>
> [ snip ]
>
> > +
> > + pm_runtime_set_autosuspend_delay(qup->dev, MSEC_PER_SEC);
> > + pm_runtime_use_autosuspend(qup->dev);
> > + pm_runtime_enable(qup->dev);
>
> Since the device is already woken up, you probably need to call
> pm_runtime_set_active here.
Thanks.
>
> Maxime
Regards,
Bjorn
next prev parent reply other threads:[~2014-02-24 18:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 0:38 [PATCH v3 0/2] Qualcomm Universal Peripheral (QUP) I2C controller Bjorn Andersson
[not found] ` <1392943090-30556-1-git-send-email-bjorn.andersson-/MT0OVThwyLZJqsBc5GL+g@public.gmane.org>
2014-02-21 0:38 ` [PATCH v3 1/2] i2c: qup: Add device tree bindings information Bjorn Andersson
2014-02-21 11:01 ` Mark Rutland
2014-02-21 0:38 ` [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller Bjorn Andersson
2014-02-21 0:52 ` Joe Perches
2014-02-24 17:51 ` Bjorn Andersson
2014-02-21 2:53 ` Emilio López
2014-02-24 18:00 ` Bjorn Andersson
2014-02-21 8:16 ` Maxime Ripard
2014-02-24 18:03 ` Bjorn Andersson [this message]
2014-02-21 11:06 ` Mark Rutland
2014-02-25 16:07 ` Bjorn Andersson
2014-02-25 16:56 ` Andy Gross
[not found] ` <1392943090-30556-3-git-send-email-bjorn.andersson-/MT0OVThwyLZJqsBc5GL+g@public.gmane.org>
2014-02-21 15:35 ` Kumar Gala
2014-02-24 10:33 ` Ivan T. Ivanov
2014-02-24 17:40 ` Josh Cartwright
2014-02-24 18:05 ` Bjorn Andersson
2014-03-05 16:44 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140224180330.GD32621@sonymobile.com \
--to=bjorn.andersson@sonymobile.com \
--cc=agross@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=iivanov@mm-sol.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=pawel.moll@arm.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).