From: Baruch Siach <baruch@tkos.co.il>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
mark.rutland@arm.com, linux-samsung-soc@vger.kernel.org,
a.hajda@samsung.com, kyungmin.park@samsung.com,
robh+dt@kernel.org, galak@codeaurora.org, kgene.kim@samsung.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 04/10] V4L: Add driver for s5k6a3 image sensor
Date: Mon, 24 Feb 2014 21:38:38 +0200 [thread overview]
Message-ID: <20140224193838.GL4869@tarshish> (raw)
In-Reply-To: <1393263322-28215-5-git-send-email-s.nawrocki@samsung.com>
Hi Sylwester,
On Mon, Feb 24, 2014 at 06:35:16PM +0100, Sylwester Nawrocki wrote:
> This patch adds subdev driver for Samsung S5K6A3 raw image sensor.
> As it is intended at the moment to be used only with the Exynos
> FIMC-IS (camera ISP) subsystem it is pretty minimal subdev driver.
> It doesn't do any I2C communication since the sensor is controlled
> by the ISP and its own firmware.
> This driver, if needed, can be updated in future into a regular
> subdev driver where the main CPU communicates with the sensor
> directly.
>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
[...]
> +static int s5k6a3_open(struct v4l2_subdev *sd, struct v4l2_subdev_fh *fh)
> +{
> + struct v4l2_mbus_framefmt *format = v4l2_subdev_get_try_format(fh, 0);
> +
> + *format = s5k6a3_formats[0];
> + format->width = S5K6A3_DEFAULT_WIDTH;
> + format->height = S5K6A3_DEFAULT_HEIGHT;
> +
> + return 0;
> +}
> +
> +static const struct v4l2_subdev_internal_ops s5k6a3_sd_internal_ops = {
> + .open = s5k6a3_open,
> +};
Where is this used?
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2014-02-24 19:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 17:35 [PATCH v5 00/10] Add device tree support for Exynos4 camera interface Sylwester Nawrocki
2014-02-24 17:35 ` [PATCH v5 01/10] Documentation: dt: Add binding documentation for S5K6A3 image sensor Sylwester Nawrocki
2014-02-24 17:35 ` [PATCH v5 02/10] Documentation: dt: Add binding documentation for S5C73M3 camera Sylwester Nawrocki
2014-02-24 17:35 ` [PATCH v5 03/10] Documentation: devicetree: Update Samsung FIMC DT binding Sylwester Nawrocki
2014-02-24 17:35 ` [PATCH v5 04/10] V4L: Add driver for s5k6a3 image sensor Sylwester Nawrocki
2014-02-24 19:38 ` Baruch Siach [this message]
2014-02-25 9:46 ` Sylwester Nawrocki
2014-02-25 9:55 ` Baruch Siach
2014-02-25 13:37 ` Sylwester Nawrocki
2014-02-24 17:35 ` [PATCH v5 05/10] V4L: s5c73m3: Add device tree support Sylwester Nawrocki
2014-02-24 17:35 ` [PATCH v5 06/10] exynos4-is: Use external s5k6a3 sensor driver Sylwester Nawrocki
2014-02-24 17:35 ` [PATCH v5 07/10] exynos4-is: Add clock provider for the SCLK_CAM clock outputs Sylwester Nawrocki
2014-02-24 17:35 ` [PATCH v5 08/10] exynos4-is: Add support for asynchronous subdevices registration Sylwester Nawrocki
2014-02-24 17:35 ` [PATCH v5 09/10] ARM: dts: Add rear camera nodes for Exynos4412 TRATS2 board Sylwester Nawrocki
2014-02-24 17:35 ` [PATCH v5 10/10] ARM: dts: exynos4: Update camera clk provider and s5k6a3 sensor node Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140224193838.GL4869@tarshish \
--to=baruch@tkos.co.il \
--cc=a.hajda@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).