From: Lee Jones <lee.jones@linaro.org>
To: Roger Quadros <rogerq@ti.com>
Cc: tony@atomide.com, bcousson@baylibre.com, balbi@ti.com, nm@ti.com,
khilman@linaro.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-usb@vger.kernel.org, Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH v8 03/14] mfd: omap-usb-host: Use clock names as per function for reference clocks
Date: Tue, 25 Feb 2014 08:52:34 +0000 [thread overview]
Message-ID: <20140225085234.GB19099@lee--X1> (raw)
In-Reply-To: <1392896409-5101-4-git-send-email-rogerq@ti.com>
> Use a meaningful name for the reference clocks so that it indicates the function.
>
> CC: Lee Jones <lee.jones@linaro.org>
> CC: Samuel Ortiz <sameo@linux.intel.com>
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
> drivers/mfd/omap-usb-host.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
> index 865c276..651e249 100644
> --- a/drivers/mfd/omap-usb-host.c
> +++ b/drivers/mfd/omap-usb-host.c
> @@ -718,24 +718,24 @@ static int usbhs_omap_probe(struct platform_device *pdev)
> goto err_mem;
> }
>
> - omap->xclk60mhsp1_ck = devm_clk_get(dev, "xclk60mhsp1_ck");
> + omap->xclk60mhsp1_ck = devm_clk_get(dev, "refclk_60m_ext_p1");
> if (IS_ERR(omap->xclk60mhsp1_ck)) {
> ret = PTR_ERR(omap->xclk60mhsp1_ck);
> - dev_err(dev, "xclk60mhsp1_ck failed error:%d\n", ret);
> + dev_err(dev, "refclk_60m_ext_p1 failed error:%d\n", ret);
> goto err_mem;
> }
Will anything break if I were to apply the MFD patches seperately?
> - omap->xclk60mhsp2_ck = devm_clk_get(dev, "xclk60mhsp2_ck");
> + omap->xclk60mhsp2_ck = devm_clk_get(dev, "refclk_60m_ext_p2");
> if (IS_ERR(omap->xclk60mhsp2_ck)) {
> ret = PTR_ERR(omap->xclk60mhsp2_ck);
> - dev_err(dev, "xclk60mhsp2_ck failed error:%d\n", ret);
> + dev_err(dev, "refclk_60m_ext_p2 failed error:%d\n", ret);
> goto err_mem;
> }
>
> - omap->init_60m_fclk = devm_clk_get(dev, "init_60m_fclk");
> + omap->init_60m_fclk = devm_clk_get(dev, "refclk_60m_int");
> if (IS_ERR(omap->init_60m_fclk)) {
> ret = PTR_ERR(omap->init_60m_fclk);
> - dev_err(dev, "init_60m_fclk failed error:%d\n", ret);
> + dev_err(dev, "refclk_60m_int failed error:%d\n", ret);
> goto err_mem;
> }
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-02-25 8:52 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 11:39 [PATCH v8 00/14] USB Host support for OMAP5 uEVM Roger Quadros
2014-02-20 11:39 ` [PATCH v8 01/14] mfd: omap-usb-host: Get clocks based on hardware revision Roger Quadros
2014-02-25 9:37 ` Lee Jones
2014-02-25 9:40 ` Roger Quadros
2014-02-20 11:39 ` [PATCH v8 02/14] mfd: omap-usb-host: Always fail on clk_get() error Roger Quadros
[not found] ` <1392896409-5101-3-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2014-02-25 9:59 ` Lee Jones
2014-02-25 10:28 ` Lee Jones
2014-02-20 11:39 ` [PATCH v8 03/14] mfd: omap-usb-host: Use clock names as per function for reference clocks Roger Quadros
2014-02-25 8:52 ` Lee Jones [this message]
2014-02-25 9:02 ` Roger Quadros
2014-02-25 9:18 ` Lee Jones
2014-02-25 9:25 ` Roger Quadros
2014-02-20 11:39 ` [PATCH v8 04/14] mfd: omap-usb-host: Update DT clock binding information Roger Quadros
2014-02-20 11:40 ` [PATCH v8 05/14] mfd: omap-usb-tll: " Roger Quadros
2014-02-20 11:40 ` [PATCH v8 06/14] CLK: TI: OMAP3: Get rid of unused USB Host dummy clocks Roger Quadros
2014-02-25 8:43 ` Mike Turquette
2014-02-25 9:32 ` Roger Quadros
2014-02-26 20:56 ` Mike Turquette
2014-02-20 11:40 ` [PATCH v8 07/14] ARM: OMAP3: hwmod data: Remove optional clock from usb_host_hs module Roger Quadros
2014-02-20 11:40 ` [PATCH v8 08/14] ARM: dts: omap4: Update omap-usb-host node Roger Quadros
2014-02-20 11:40 ` [PATCH v8 09/14] ARM: dts: omap5: " Roger Quadros
2014-02-20 11:40 ` [PATCH v8 10/14] ARM: dts: omap4-panda: Provide USB PHY clock Roger Quadros
2014-02-20 11:40 ` [PATCH v8 11/14] ARM: dts: omap5-uevm: " Roger Quadros
2014-02-20 11:40 ` [PATCH v8 12/14] ARM: OMAP2+: Remove legacy_init_ehci_clk() Roger Quadros
[not found] ` <1392896409-5101-1-git-send-email-rogerq-l0cyMroinI0@public.gmane.org>
2014-02-20 11:40 ` [PATCH v8 13/14] ARM: dts: OMAP2+: Get rid of incompatible ids for USB host nodes Roger Quadros
2014-02-20 11:40 ` [PATCH v8 14/14] usb: omap: dts: Update DT binding example usage Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140225085234.GB19099@lee--X1 \
--to=lee.jones@linaro.org \
--cc=balbi@ti.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nm@ti.com \
--cc=rogerq@ti.com \
--cc=sameo@linux.intel.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).