Re: [PATCHv1 3/6] HSI: hsi-char: add Device Tree support

[Sebastian Reichel <sre-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1636 bytes --]

On Mon, Feb 24, 2014 at 03:13:01PM +0000, Mark Rutland wrote:
> On Sun, Feb 23, 2014 at 11:49:58PM +0000, Sebastian Reichel wrote:
> > Add of_match_table to hsi_char driver, so that it can
> > be referenced from Device Tree.
> > 
> > Signed-off-by: Sebastian Reichel <sre-8fiUuRrzOP0dnm+yROfE0A@public.gmane.org>
> > ---
> >  drivers/hsi/clients/hsi_char.c | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> > 
> > diff --git a/drivers/hsi/clients/hsi_char.c b/drivers/hsi/clients/hsi_char.c
> > index e61e5f9..7f64bed 100644
> > --- a/drivers/hsi/clients/hsi_char.c
> > +++ b/drivers/hsi/clients/hsi_char.c
> > @@ -42,6 +42,7 @@
> >  #include <linux/stat.h>
> >  #include <linux/hsi/hsi.h>
> >  #include <linux/hsi/hsi_char.h>
> > +#include <linux/of_device.h>
> >  
> >  #define HSC_DEVS		16 /* Num of channels */
> >  #define HSC_MSGS		4
> > @@ -758,12 +759,22 @@ static int hsc_remove(struct device *dev)
> >  	return 0;
> >  }
> >  
> > +#ifdef CONFIG_OF
> > +static const struct of_device_id hsi_char_of_match[] = {
> > +	{ .compatible = "ssi-char", },
> 
> This string is undocumented.
> 
> > +	{ .compatible = "hsi-char", },
> 
> I'm not sure either string makes sense though; this feels like a binding
> for the sake of the driver rather than describing the device and
> allowing the driver to pick it up if it makes sense to do so.
> 
> What exactly is a "ssi-char" device or a "hsi-char" device?

mh. I guess I will update the hsi framework, so that it simply loads
the client driver for each registered port. This is indeed only a
binding to load the driver.

-- Sebastian

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]