Re: [PATCH v2] phy-rcar-gen2-usb: add device tree support

[Felipe Balbi <balbi@ti.com>]

[-- Attachment #1: Type: text/plain, Size: 2722 bytes --]

Hi,

On Mon, Mar 03, 2014 at 08:50:33PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 03/03/2014 07:44 PM, Felipe Balbi wrote:
> 
> >>Add support of the device tree probing for the Renesas R-Car generation 2 SoCs
> >>documenting the device tree binding as necessary.
> 
> >>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> >Unless someone on devicetree@vger gives me an ACK pretty soon, I'm
> >afraid this patch will miss v3.15.
> 
>    Ugh, the USB acceptance window is getting very short...

well, -rc5 is already out... I want to have at least 2 weeks of
"linux-next soakage" (yes, I just coined a new term heh). Since most
releases go up to -rc7, it's about time to close the tree ;-)

> >>---
> >>This patch is against the 'next' branch of Felipe Balbi's 'usb.git' repo.
> >>
> >>Changes in version 2:
> >>- restored devm_clk_get() call and the error handling logic in the probe()
> >>   method, removed clk_put() call in the remove() method.
> 
> >>  Documentation/devicetree/bindings/usb/rcar-gen2-phy.txt |   29 +++++++++++
> >>  drivers/usb/phy/phy-rcar-gen2-usb.c                     |   42 ++++++++++++++--
> >>  2 files changed, 68 insertions(+), 3 deletions(-)
> 
> >>Index: usb/Documentation/devicetree/bindings/usb/rcar-gen2-phy.txt
> >>===================================================================
> >>--- /dev/null
> >>+++ usb/Documentation/devicetree/bindings/usb/rcar-gen2-phy.txt
> >>@@ -0,0 +1,29 @@
> >>+* Renesas R-Car generation 2 USB PHY
> >>+
> >>+This file provides information on what the device node for the R-Car generation
> >>+2 USB PHY contains.
> >>+
> >>+Required properties:
> >>+- compatible: "renesas,usb-phy-r8a7790" if the device is a part of R8A7790 SoC.
> >>+	      "renesas,usb-phy-r8a7791" if the device is a part of R8A7791 SoC.
> >>+- reg: offset and length of the register block.
> >>+- clocks: clock phandle and specifier pair.
> >>+- clock-names: string, clock input name, must be "usbhs".
> >>+
> >>+Optional properties:
> >>+- renesas,channel0-pci: boolean, specify when USB channel 0 should be connected
> >>+			to PCI EHCI/OHCI; otherwise, it will be connected to the
> >>+			USBHS controller.
> >>+- renesas,channel2-pci: boolean, specify when USB channel 2 should be connected
> >>+			to PCI EHCI/OHCI; otherwise, it will be connected to the
> >>+			USBSS controller (xHCI).
> 
> >I wonder if these two properties should be taken care by pinctrl
> >framework instead.
> 
>    No, the internal port multiplexing is controlled by the PHY
> itself, see the driver source. The same way it was with USB port 1 of
> the generation 1 R-Car SoCs.

ok, fair enough.

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]