From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Mark A. Greer" Subject: Re: [PATCH 1/3] NFC: trf7970a: Add driver with ISO/IEC 14443 Type 2 Tag Support Date: Mon, 3 Mar 2014 11:11:12 -0700 Message-ID: <20140303181112.GA32605@animalcreek.com> References: <1391206631-9862-1-git-send-email-mgreer@animalcreek.com> <1391206631-9862-2-git-send-email-mgreer@animalcreek.com> <20140221005059.GS18868@zurbaran> <20140226215309.GA21867@animalcreek.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20140226215309.GA21867-luAo+O/VEmrlveNOaEYElw@public.gmane.org> Sender: linux-wireless-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Samuel Ortiz Cc: Lauro Ramos Venancio , Aloisio Almeida Jr , Felipe Balbi , Erick Macias , Thierry Escande , linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-nfc-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org On Wed, Feb 26, 2014 at 02:53:09PM -0700, Mark A. Greer wrote: > On Fri, Feb 21, 2014 at 01:50:59AM +0100, Samuel Ortiz wrote: > > Hi Mark, > > Hi Samuel - thanks for the feedback. > > > Code looks quite nice, especially since this looks like a fairly complex > > driver. And the initial coments are quite useful, I appreciate that. > > I have a few comments/questions though: > > > > > > > + * been received and there isn't an error). The delay is 3 ms since delays > > > + * over 2 ms have been observed during testing. > > Would you say this timeout depend on the SPI bus bandwidth ? > > It'll be one of the factors but the tag's response characteristics are > a big factor too. I can bump it up a bit more if you prefer or do you > want me to somehow calculate it from the SPI bitrate? Ping. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html