From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
To: Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>
Cc: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
Device Tree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux ARM
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH 3/3] ARM: Kirkwood: DT: Add missing vendor prefix
Date: Tue, 4 Mar 2014 10:28:54 +0100 [thread overview]
Message-ID: <20140304092854.GI16655@lunn.ch> (raw)
In-Reply-To: <20140304030522.GZ1872-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
On Mon, Mar 03, 2014 at 10:05:22PM -0500, Jason Cooper wrote:
> Andrew,
>
> Couple of stupid questions:
>
> - I haven't seen 0/1 nor 1/1 show up anywhere (dt, lakml, inbox), am I
> missing something?
Humm, i will check, and do a resend if needed.
> On Sun, Mar 02, 2014 at 04:24:15PM +0100, Andrew Lunn wrote:
> > Add vendor prefixes to compatible strings where they are missing.
> >
> > Signed-off-by: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
> > ---
> > arch/arm/boot/dts/kirkwood-b3.dts | 2 +-
> > arch/arm/boot/dts/kirkwood-cloudbox.dts | 2 +-
> > arch/arm/boot/dts/kirkwood-dreamplug.dts | 2 +-
> > arch/arm/boot/dts/kirkwood-mv88f6281gtw-ge.dts | 2 +-
> > arch/arm/boot/dts/kirkwood-ns2-common.dtsi | 2 +-
> > arch/arm/boot/dts/kirkwood-nsa310.dts | 2 +-
> > arch/arm/boot/dts/kirkwood-nsa310a.dts | 2 +-
> > arch/arm/boot/dts/kirkwood-openblocks_a6.dts | 2 +-
> > arch/arm/boot/dts/kirkwood-openblocks_a7.dts | 2 +-
> > 9 files changed, 9 insertions(+), 9 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/kirkwood-b3.dts b/arch/arm/boot/dts/kirkwood-b3.dts
> > index 40791053106b..6becedebaa4e 100644
> > --- a/arch/arm/boot/dts/kirkwood-b3.dts
> > +++ b/arch/arm/boot/dts/kirkwood-b3.dts
> > @@ -75,7 +75,7 @@
> > m25p16@0 {
> > #address-cells = <1>;
> > #size-cells = <1>;
> > - compatible = "m25p16";
> > + compatible = "st,m25p16";
>
> Have you checked that the drivers for each of these changes already
> support the new compatible strings?
I2c and MTD ignore the vendor string when performing matches. However,
checkpatch.pl does not. It is also technically correct to have a
vendor string.
Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2014-03-04 9:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-02 15:24 [PATCH 1/3] DT: I2C: Add trivial bindings used by kirkwood boards Andrew Lunn
[not found] ` <1393773855-9592-1-git-send-email-andrew-g2DYL2Zd6BY@public.gmane.org>
2014-03-02 15:24 ` [PATCH 2/3] DT: Vendors: Add vendor prefix for Macronix Andrew Lunn
2014-03-02 15:24 ` [PATCH 3/3] ARM: Kirkwood: DT: Add missing vendor prefix Andrew Lunn
[not found] ` <1393773855-9592-3-git-send-email-andrew-g2DYL2Zd6BY@public.gmane.org>
2014-03-04 3:05 ` Jason Cooper
[not found] ` <20140304030522.GZ1872-u4khhh1J0LxI1Ri9qeTfzeTW4wlIGRCZ@public.gmane.org>
2014-03-04 9:28 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140304092854.GI16655@lunn.ch \
--to=andrew-g2dyl2zd6by@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).