Re: [PATCH v2 0/7] Watchdog support for Armada 375/38x SoC

Ezequiel Garcia
2014-03-07T00:13:46Z

On Mar 04, Ezequiel Garcia wrote:
> Here's a new patchset adding support for watchdog on Armada 375 and
> Armada 38x SoCs. Regarding the previous patchset, this time we're handling
> the SoCs differences in the watchdog driver itself.
>
> The new Armada 375/385 SoCs have two registers for the watchdog RSTOUT:
>
> 1. It has a dedicated register (similar to the one in A370/XP)
> 2. Also has a bit in a shared RSTOUT register.
>
> Therefore, in order to support this two-folded RSTOUT, we extend the 'reg'
> property in the watchdog devicetree and require a new pair of cells to specify
> the shared RSTOUT.
>
> On the driver side, we need to implement per-SoC stop() and enabled()
> functions. Such somewhat complex infrastructure is needed to ensure the driver
> performs proper reset of the watchdog timer, by masking and disabling the
> RSTOUT before the interrupt is enabled.
>

JasonG: How does this look now?

Any chance someone gives a Tested-by on Dove/Kirkwood?
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering