From: Sebastian Reichel <sre@ring0.de>
To: Sebastian Reichel <sre@ring0.de>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Carlos Chinea <cch.devel@gmail.com>,
Shubhrajyoti Datta <omaplinuxkernel@gmail.com>,
Dmitry Tarnyagin <dmitry.tarnyagin@lockless.no>,
Pawel Szyszuk <pawel.szyszuk@stericsson.com>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>
Subject: Generic HSI client DT bindings
Date: Mon, 10 Mar 2014 00:41:44 +0100 [thread overview]
Message-ID: <20140309234143.GA19034@earth.universe> (raw)
[-- Attachment #1: Type: text/plain, Size: 2518 bytes --]
Hi,
I'm currently working on Device Tree support for the HSI subsystem
to get the Nokia N900 modem working in the mainline kernel. I guess
the key question for the binding has been asked by Mark:
Mark Rutland <mark.rutland@arm.com> wrote [0]:
> Does HSI have an addressing scheme, or does each port
> have a single device?
It's easy to answer the question in an abstract way: A HSI link
connects two processors with each other providing multiple logical
channels. The problem is, that only the physical layer is specified
AFAIK (I do not have access to HSI specification, so I do not know
for sure). Thus the exact usage of the channels is vendor specific.
For the Nokia N900 modem the following one of the following bindings
seem senseful to me:
========= Variant A =========
hsi-port {
/* some nodes describing the port */
n900_modem: client-device {
compatible = "nokia,n900-modem";
reg = <0>, <1>, <2>, <3>;
reg-names = "mcsaab-control",
"speech-control",
"mcsaab-data",
"speech-data";
hsi-mode = "stream";
hsi-speed-kbps = <55000>;
hsi-flow = "synchronized";
hsi-arb-mode = "round-robin";
};
};
#############################
========= Variant B =========
hsi-port {
/* some nodes describing the port */
cmt_mcsaab: client-device@0 {
compatible = "nokia,mcsaab-protocol";
reg = <0>, <2>;
reg-names = "mcsaab-control",
"mcsaab-data";
hsi-mode = "stream";
hsi-channels = <4>;
hsi-speed-kbps = <55000>;
hsi-flow = "synchronized";
hsi-arb-mode = "round-robin";
};
cmt_speech: client-device@1 {
compatible = "nokia,cmt-speech";
reg = <1>, <4>;
reg-names = "speech-control",
"speech-data";
hsi-mode = "stream";
hsi-channels = <4>;
hsi-speed-kbps = <55000>;
hsi-flow = "synchronized";
hsi-arb-mode = "round-robin";
};
};
#############################
Both bindings are simplified and do not map all of the hardware's
capabilities: Some settings can be configured differently for RX and
TX. It should be easy to extend the support for e.g. hsi-mode-rx
and hsi-mode-tx once this is needed. For devices configuring them
the same having just one node seems better to me (I assume almost
all devices want them to be the same).
As far as I can see only ST-Erricson has also HSI clients prepared
for the mainline kernel. It would be nice to get some feedback from
you. If you know more HSI users, which are not yet Cc'd please feel
free to point them here.
[0] http://article.gmane.org/gmane.linux.kernel/1654456
-- Sebastian
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
reply other threads:[~2014-03-09 23:41 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140309234143.GA19034@earth.universe \
--to=sre@ring0.de \
--cc=cch.devel@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.tarnyagin@lockless.no \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=omaplinuxkernel@gmail.com \
--cc=pawel.moll@arm.com \
--cc=pawel.szyszuk@stericsson.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).