From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Porter Subject: Re: [PATCH v3 2/5] mfd: add bcm590xx pmu driver Date: Tue, 11 Mar 2014 19:25:45 -0400 Message-ID: <20140311232545.GP25092@beef> References: <1394552775-31264-1-git-send-email-mporter@linaro.org> <1394552775-31264-3-git-send-email-mporter@linaro.org> <20140311160837.GP21216@lee--X1> <20140311221938.GO25092@beef> <20140311224517.GA5672@lee--X1> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20140311224517.GA5672@lee--X1> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Lee Jones Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Samuel Ortiz , Liam Girdwood , Mark Brown , Christian Daudt , Devicetree List , Linux ARM Kernel List , Linux Kernel Mailing List List-Id: devicetree@vger.kernel.org On Tue, Mar 11, 2014 at 10:45:17PM +0000, Lee Jones wrote: > > > > Add a driver for the BCM590xx PMU multi-function devices. The driver > > > > initially supports regmap initialization and instantiation of the > > > > voltage regulator device function of the PMU. > > > > > > > > Signed-off-by: Matt Porter > > > > Reviewed-by: Tim Kryger > > > > Reviewed-by: Markus Mayer > > > > --- > > > > drivers/mfd/Kconfig | 8 ++++ > > > > drivers/mfd/Makefile | 1 + > > > > drivers/mfd/bcm590xx.c | 93 ++++++++++++++++++++++++++++++++++++++++++++ > > > > include/linux/mfd/bcm590xx.h | 31 +++++++++++++++ > > > > 4 files changed, 133 insertions(+) > > > > create mode 100644 drivers/mfd/bcm590xx.c > > > > create mode 100644 include/linux/mfd/bcm590xx.h > > > > > > I have a tiny nit that 'ret' doesn't need to be initialised before > > > use in probe(), but apart from that... > > > > > > Looks pretty sensible: > > > Acked-by: Lee Jones > > > > Ok, thanks. When I get back in front of my desktop I'll send a v4 of > > just this patch to address that nit. Mark already applied the regulator > > driver from this series, will you be taking this through your tree? For > > that matter, I wonder if the binding would also go through your tree > > with this driver. > > At least the MFD portion and the DT binding doc will go through the > MFD tree. > > Are there any inter-patch dependencies in the set? If so, we should > know about them so we can coordinate a sensible solution. Yes, the regulator driver (3/5) that Mark applied is dependent on this patch...the regulator driver includes include/linux/mfd/bcm590xx.h. -Matt -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html